Skip to content

Commit 45cfe8d

Browse files
committed
chore: tidy up test
1 parent bbd039f commit 45cfe8d

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

app/core/RPCMethods/RPCMethodMiddleware.test.ts

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -845,15 +845,14 @@ describe('getRpcMethodMiddleware', () => {
845845
method: 'eth_sendTransaction',
846846
params: [mockTransactionParameters],
847847
};
848-
const expectedError = rpcErrors.internal('Failed to add transaction');
848+
const expectedError = rpcErrors.internal('Internal JSON-RPC error.');
849849

850850
const response = await callMiddleware({ middleware, request });
851851

852852
console.error((response as JsonRpcFailure).error);
853853
expect((response as JsonRpcFailure).error.code).toBe(expectedError.code);
854854
expect((response as JsonRpcFailure).error.message).toBe(
855-
'Internal JSON-RPC error.',
856-
// expectedError.message,
855+
expectedError.message,
857856
);
858857
});
859858

@@ -876,14 +875,13 @@ describe('getRpcMethodMiddleware', () => {
876875
method: 'eth_sendTransaction',
877876
params: [mockTransactionParameters],
878877
};
879-
const expectedError = rpcErrors.internal('Failed to process transaction');
878+
const expectedError = rpcErrors.internal('Internal JSON-RPC error.');
880879

881880
const response = await callMiddleware({ middleware, request });
882881

883882
expect((response as JsonRpcFailure).error.code).toBe(expectedError.code);
884883
expect((response as JsonRpcFailure).error.message).toBe(
885-
// expectedError.message,
886-
'Internal JSON-RPC error.',
884+
expectedError.message,
887885
);
888886
});
889887
});
@@ -950,14 +948,13 @@ describe('getRpcMethodMiddleware', () => {
950948
method: 'personal_ecRecover',
951949
params: [helloWorldMessage],
952950
};
953-
const expectedError = rpcErrors.internal('Missing signature parameter');
951+
const expectedError = rpcErrors.internal('Internal JSON-RPC error.');
954952

955953
const response = await callMiddleware({ middleware, request });
956954

957955
expect((response as JsonRpcFailure).error.code).toBe(expectedError.code);
958956
expect((response as JsonRpcFailure).error.message).toBe(
959-
// expectedError.message,
960-
'Internal JSON-RPC error.',
957+
expectedError.message,
961958
);
962959
});
963960

@@ -972,14 +969,13 @@ describe('getRpcMethodMiddleware', () => {
972969
method: 'personal_ecRecover',
973970
params: [undefined, helloWorldSignature] as JsonRpcParams,
974971
};
975-
const expectedError = rpcErrors.internal('Missing data parameter');
972+
const expectedError = rpcErrors.internal('Internal JSON-RPC error.');
976973

977974
const response = await callMiddleware({ middleware, request });
978975

979976
expect((response as JsonRpcFailure).error.code).toBe(expectedError.code);
980977
expect((response as JsonRpcFailure).error.message).toBe(
981-
// expectedError.message,
982-
'Internal JSON-RPC error.',
978+
expectedError.message,
983979
);
984980
});
985981
});

0 commit comments

Comments
 (0)