Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Apr 10, 2024

Description

This PR removes old announcements for the "Snaps Open Beta" and the "Buy & Sell" feature. This PR also adds a date to the simulations announcement, effectively sorting it to the top (by request of @Montoya).

Open in GitHub Codespaces

@FrederikBolding FrederikBolding added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Apr 10, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner April 10, 2024 15:42
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 10, 2024
@Montoya Montoya added team-core-extension-ux Core Extension UX team and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 10, 2024
@Montoya
Copy link
Contributor

Montoya commented Apr 10, 2024

Hi @MetaMask/extension-admins, this change is agreed to by product leads for Wallet UX, Ramps, and Snaps.

@metamaskbot
Copy link
Collaborator

Builds ready [57ac8a8]
Page Load Metrics (868 ± 515 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint741611082612
domContentLoaded106326115
load6125148681073515
domInteractive106326115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -430 Bytes (-0.01%)
  • common: -1.86 KiB (-0.03%)

@codecov
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.47%. Comparing base (ab2fa3e) to head (57ac8a8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23940      +/-   ##
===========================================
- Coverage    67.49%   67.47%   -0.02%     
===========================================
  Files         1244     1244              
  Lines        48778    48772       -6     
  Branches     12726    12721       -5     
===========================================
- Hits         32921    32907      -14     
- Misses       15857    15865       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 2e021ee into develop Apr 11, 2024
@FrederikBolding FrederikBolding deleted the fb/remove-old-announcements branch April 11, 2024 07:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-core-extension-ux Core Extension UX team team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants