chore: Upgrade assets-controllers to latest #23574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
force-pushed
the
feat/update-assets-controllers
branch
2 times, most recently
from
418cf58 to
cc51c2f
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/assets-controllers@26.0.0, npm/@metamask/polling-controller@5.0.1, npm/@metamask/preferences-controller@8.0.0 |
sahar-fehri
changed the title
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
3 tasks
sahar-fehri
added a commit
to MetaMask/core
that referenced
this pull request
Mar 19, 2024
## Explanation
PR to export `SUPPORTED_CHAIN_IDS` constant.
This constant is imported in extension like this:
`import { SUPPORTED_CHAIN_IDS } from
'@metamask/assets-controllers/dist/token-prices-service/codefi-v2';`
Which was causing issues when trying to upgrade assets-controllers to
latest. It was not able to find it.
With this change we can import it like this instead of from dist which
can abstract how the code is transpiled;
`import { SUPPORTED_CHAIN_IDS } from '@metamask/assets-controllers';`
## References
* Related to
[#67890](MetaMask/metamask-extension#23574)
## Changelog
<!--
If you're making any consumer-facing changes, list those changes here as
if you were updating a changelog, using the template below as a guide.
(CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
FIXED. For security-related issues, follow the Security Advisory
process.)
Please take care to name the exact pieces of the API you've added or
changed (e.g. types, interfaces, functions, or methods).
If there are any breaking changes, make sure to offer a solution for
consumers to follow once they upgrade to the changes.
Finally, if you're only making changes to development scripts or tests,
you may replace the template below with "None".
-->
### `@metamask/assets-controllers`
- **ADDED**: Added export for const SUPPORTED_CHAIN_IDS
## Checklist
- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
sahar-fehri
force-pushed
the
feat/update-assets-controllers
branch
from
5ecc402 to
49511a3
Compare
Collaborator
Builds ready [567e5f7]
Page Load Metrics (1009 ± 494 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
hesterbruikman
added
team-assets
and removed
team-core-extension-ux
Contributor
Author
|
Closing this one, no need to merge anymore will create a new PR for the new latest assets-controllers version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to update assets-controllers to
v27.2.0.Changelogs:
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist