Skip to content

Conversation

@FrederikBolding
Copy link
Member

Description

Bump snaps packages to latest.

Summary of changes in the snaps deps:

  • Handle unavailable registry more gracefully
  • Update markdown parsing for better link validation
  • Fix address validation in row component
  • Update dependencies

@FrederikBolding FrederikBolding added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Mar 12, 2024
@FrederikBolding FrederikBolding requested review from a team as code owners March 12, 2024 12:41
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 12, 2024
@socket-security
Copy link

socket-security bot commented Mar 12, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/marked@12.0.1 None 0 923 kB tonybrix

View full report↗︎

Comment on lines +2225 to +2243
"globals": {
"Hooks": true,
"Lexer": true,
"Parser": true,
"Renderer": true,
"TextRenderer": true,
"Tokenizer": true,
"console.error": true,
"console.warn": true,
"defaults": true,
"define": true,
"inlineQueue": true,
"passThroughHooks": true,
"renderer": true,
"rules": true,
"state": true,
"textRenderer": true,
"tokenizer": true,
"tokens": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this. It's harmless tho.

naugtur
naugtur previously approved these changes Mar 12, 2024
Mrtenz
Mrtenz previously approved these changes Mar 12, 2024
@FrederikBolding FrederikBolding dismissed stale reviews from Mrtenz and naugtur via 6aff182 March 12, 2024 13:23
@metamaskbot
Copy link
Collaborator

Builds ready [6aff182]
Page Load Metrics (806 ± 425 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint741971152914
domContentLoaded106225126
load582052806886425
domInteractive106225126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 305 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 34.96 KiB (0.75%)

@bowensanders
Copy link
Contributor

QA Passes ✅

@FrederikBolding FrederikBolding merged commit 421c3dc into develop Mar 13, 2024
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v38 branch March 13, 2024 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants