Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Mar 7, 2024

Description

Bumps snaps-registry to the latest version. This package contains the validation logic for the Snaps registry. This validation logic was flawed for signatures of certain lengths and caused a production outage.

For more context: MetaMask/snaps-registry#471

Open in GitHub Codespaces

@FrederikBolding FrederikBolding added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Mar 7, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner March 7, 2024 20:14
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 7, 2024
@FrederikBolding FrederikBolding merged commit c75aab0 into develop Mar 7, 2024
@FrederikBolding FrederikBolding deleted the fb/bump-snaps-registry branch March 7, 2024 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [cfa8990]
Page Load Metrics (1313 ± 383 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint952111473316
domContentLoaded1384392311
load7623881313797383
domInteractive1384392311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 246 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants