Skip to content

Conversation

@zone-live
Copy link
Contributor

@zone-live zone-live commented Mar 6, 2024

Description

We are moving our mmi controller to TS, this PR is the start of that.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Mar 6, 2024
@zone-live zone-live requested a review from a team as a code owner March 6, 2024 14:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live requested a review from albertolive March 6, 2024 14:55
@codecov
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 5.17241% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 68.68%. Comparing base (be87264) to head (c744ba8).

Files Patch % Lines
app/scripts/controllers/mmi-controller.ts 5.17% 55 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23347      +/-   ##
===========================================
- Coverage    68.72%   68.68%   -0.04%     
===========================================
  Files         1105     1105              
  Lines        43250    43268      +18     
  Branches     11562    11566       +4     
===========================================
- Hits         29720    29715       -5     
- Misses       13530    13553      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [c744ba8]
Page Load Metrics (1497 ± 395 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint812431514823
domContentLoaded1278372110
load5623731497823395
domInteractive1278372110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 153c6a1 into develop Mar 12, 2024
@zone-live zone-live deleted the MMI-3772-mmi-controller-ts branch March 12, 2024 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mmi DEPRECATED: The product got sunset release-11.14.0 Issue or pull request that will be included in release 11.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants