Skip to content

Conversation

@darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 17, 2024

Description

Creates a simple Disconnect All modal which can be used for both Accounts and Snaps

Related issues

Fixes: 2212

Fixes: 2212

Manual testing steps

  1. Go to storybook
  2. Check the Disconnect all Modal design is same as figma

Screenshots/Recordings

Before

NA

After

SCR-20240217-lmpr

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Feb 17, 2024
@darkwing darkwing requested a review from a team as a code owner February 17, 2024 18:48
@darkwing darkwing marked this pull request as draft February 17, 2024 18:48
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NidhiKJha NidhiKJha marked this pull request as ready for review March 8, 2024 10:49
@NidhiKJha NidhiKJha changed the title UX - Multichain - Disconnect All Modal feat: UX - Multichain - Disconnect All Modal Mar 8, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bcffd2c]
Page Load Metrics (783 ± 410 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint752781294823
domContentLoaded10107322110
load611897783855410
domInteractive10107322110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 452 Bytes (0.01%)

@codecov
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (171b6c7) to head (8ebb9ea).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23032   +/-   ##
========================================
  Coverage    68.72%   68.72%           
========================================
  Files         1122     1123    +1     
  Lines        43577    43581    +4     
  Branches     11661    11661           
========================================
+ Hits         29945    29949    +4     
  Misses       13632    13632           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const t = useI18nContext();

return (
<Modal isOpen onClose={onClose}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a data-test-id or classname

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, this is a skeleton. We are gonna do that once we integrate this modal on button click

@metamaskbot
Copy link
Collaborator

Builds ready [8ebb9ea]
Page Load Metrics (1001 ± 401 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint771641182412
domContentLoaded96628199
load6322711001836401
domInteractive96628199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 452 Bytes (0.01%)

@NidhiKJha NidhiKJha merged commit f7a0351 into develop Mar 12, 2024
@NidhiKJha NidhiKJha deleted the disconnect-all branch March 12, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants