-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: UX - Multichain - Disconnect All Modal #23032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [bcffd2c]
Page Load Metrics (783 ± 410 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23032 +/- ##
========================================
Coverage 68.72% 68.72%
========================================
Files 1122 1123 +1
Lines 43577 43581 +4
Branches 11661 11661
========================================
+ Hits 29945 29949 +4
Misses 13632 13632 ☔ View full report in Codecov by Sentry. |
| const t = useI18nContext(); | ||
|
|
||
| return ( | ||
| <Modal isOpen onClose={onClose}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a data-test-id or classname
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since, this is a skeleton. We are gonna do that once we integrate this modal on button click
Builds ready [8ebb9ea]
Page Load Metrics (1001 ± 401 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Creates a simple Disconnect All modal which can be used for both Accounts and Snaps
Related issues
Fixes: 2212
Fixes: 2212
Manual testing steps
Screenshots/Recordings
Before
NA
After
Pre-merge author checklist
Pre-merge reviewer checklist