Skip to content

Conversation

@FrederikBolding
Copy link
Member

Description

I introduced a bug in #22850 which can be reproduced by going to the test-dapp, starting a permission request flow, proceeding to the next screen and cancelling it again. This fixes the problem by guarding against permissions being null.

Manual testing steps

  1. Go to the test-dapp
  2. Connect
  3. Click next
  4. Click cancel
  5. See that the extension does not crash

@FrederikBolding FrederikBolding added the team-snaps-deprecated DEPRECATED: please use "team-core-platform" instead label Feb 13, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner February 13, 2024 15:20
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 13, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [a87e5ab]
Page Load Metrics (1134 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1263032154220
domContentLoaded11127503617
load8701324113411957
domInteractive11127503617
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 4 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit 8a47a96 into develop Feb 13, 2024
@FrederikBolding FrederikBolding deleted the fb/fix-cancel-permission-request branch February 13, 2024 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 13, 2024
@ziedbrini ziedbrini added team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) and removed team-snaps-deprecated DEPRECATED: please use "team-core-platform" instead labels Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants