Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 8, 2024

Description

Update ppom-validator to latest version.

Related issues

#22776
#22777

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 8, 2024
@jpuri jpuri requested a review from a team as a code owner February 8, 2024 05:25
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Feb 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/ppom-validator@0.24.0 Transitive: environment, eval, filesystem, network, shell, unsafe +189 28.2 MB

🚮 Removed packages: npm/@metamask/ppom-validator@0.22.0

View full report↗︎

@socket-security
Copy link

socket-security bot commented Feb 8, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/ppom-validator@0.24.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@jpuri
Copy link
Contributor Author

jpuri commented Feb 8, 2024

@SocketSecurity ignore npm/@metamask/ppom-validator@0.23.0

@codecov
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4c12ec) 68.47% compared to head (bc1acf5) 68.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22868   +/-   ##
========================================
  Coverage    68.47%   68.47%           
========================================
  Files         1088     1088           
  Lines        42902    42902           
  Branches     11424    11424           
========================================
  Hits         29377    29377           
  Misses       13525    13525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [a701c17]
Page Load Metrics (792 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89156112178
domContentLoaded11431973
load7418607923818
domInteractive11431973
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 468 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri marked this pull request as draft February 8, 2024 06:14
@jpuri
Copy link
Contributor Author

jpuri commented Feb 8, 2024

@SocketSecurity ignore npm/@metamask/ppom-validator@0.24.0

@jpuri jpuri marked this pull request as ready for review February 8, 2024 11:02
@metamaskbot
Copy link
Collaborator

Builds ready [bc1acf5]
Page Load Metrics (815 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint771571142412
domContentLoaded95625136
load71010108157436
domInteractive95625136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 464 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit 1d4a666 into develop Feb 8, 2024
@jpuri jpuri deleted the ppom_validator_changes branch February 8, 2024 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 8, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants