[Snaps E2E] Remove / Replace superflous arbitrary delays in snaps E2E tests #22821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowensanders
added
area-snaps
team-snaps-deprecated
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22821 +/- ##
===========================================
- Coverage 68.48% 68.47% -0.01%
===========================================
Files 1088 1088
Lines 42897 42902 +5
Branches 11425 11424 -1
===========================================
- Hits 29378 29377 -1
- Misses 13519 13525 +6 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [6028508]
Page Load Metrics (773 ± 30 ms)
Bundle size diffs
|
Collaborator
Builds ready [8c67b3f]
Page Load Metrics (772 ± 22 ms)
Bundle size diffs
|
Collaborator
Builds ready [b48ab87]
Page Load Metrics (816 ± 34 ms)
Bundle size diffs
|
Member
FrederikBolding
left a comment
FrederikBolding
left a comment
There was a problem hiding this comment.
Please delete all the commented out lines before we merge this
Collaborator
Builds ready [6679084]
Page Load Metrics (699 ± 13 ms)
Bundle size diffs
|
Contributor
Author
|
comments removed |
Collaborator
Builds ready [6792e5a]
Page Load Metrics (835 ± 93 ms)
Bundle size diffs
|
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Collaborator
Builds ready [5176b1e]
Page Load Metrics (858 ± 54 ms)
Bundle size diffs
|
FrederikBolding
approved these changes
Feb 8, 2024
Collaborator
Builds ready [f184bcb]
Page Load Metrics (780 ± 15 ms)
Bundle size diffs
|
david0xd
approved these changes
Feb 9, 2024
metamaskbot
added
the
release-11.12.0
ziedbrini
added
team-snaps-platform-deprecated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to reduce the amount of CI time used by the snaps E2E tests by removing or replacing as many delays as possible without having a negative impact on test flakiness.
Fixes: 76 1000ms delays removed
24 500ms delays removed
old test-e2e-chrome-flask speeds (using v 11.10 as benchmark) -
shortest snaps test - 1m29s
longest snaps test - 2m23s
longest test in run - 3m16s (longest test is from accounts)
(see this page for details)
new test-e2e-chrome-flask speeds
shortest snaps test - 1m10s
longest snaps test - 1m52
(see this page for details) (edited)
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist