UX: Show Total Account Balances #22186

darkwing · 2023-12-06T17:22:55Z

Description

Shows total account balances in the Accounts Menu and home screen overview.

Related issues

Fixes:

Manual testing steps

Open the account list -- see account totals
See the same total on the home overview of each account

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2023-12-06T17:23:07Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-12-06T18:23:07Z

Builds ready [b7db1dd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1310 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	169	106	17	8
		domContentLoaded	10	43	16	7	3
		load	1084	1511	1310	89	43
		domInteractive	10	43	16	7	3

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 326 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2023-12-06T18:23:29Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (391e9e7) 68.55% compared to head (2e083a8) 68.55%.
Report is 2 commits behind head on develop.

Files	Patch %	Lines
ui/components/app/wallet-overview/eth-overview.js	87.50%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #22186   +/-   ##
========================================
  Coverage    68.55%   68.55%           
========================================
  Files         1088     1088           
  Lines        42907    42916    +9     
  Branches     11415    11413    -2     
========================================
+ Hits         29411    29418    +7     
- Misses       13496    13498    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ui/pages/confirmation/templates/__snapshots__/remove-snap-account.test.js.snap

metamaskbot · 2024-02-06T11:28:31Z

Builds ready [8ec6020]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (803 ± 31 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	149	113	14	7
		domContentLoaded	9	45	18	8	4
		load	714	1017	803	64	31
		domInteractive	9	45	18	8	4

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 131 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-02-08T17:35:06Z

Builds ready [3c71afc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (739 ± 18 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	130	98	13	6
		domContentLoaded	9	31	17	5	3
		load	689	840	739	37	18
		domInteractive	9	31	17	5	3

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 131 Bytes (0.00%)
common: 0 Bytes (0.00%)

darkwing

Wow @NidhiKJha , you really brought this home! Just one issue:

We aren't respecting the "Show conversions on test networks" setting, always showing fiat for test networks:

Other than that, this is good to go!

metamaskbot · 2024-02-14T14:04:31Z

Builds ready [2e083a8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (930 ± 25 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	125	382	190	49	23
		domContentLoaded	9	92	43	28	13
		load	845	1087	930	52	25
		domInteractive	9	92	43	28	13

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 762 Bytes (0.01%)
common: 40 Bytes (0.00%)

darkwing requested a review from a team as a code owner December 6, 2023 17:22

darkwing added team-extension-client labels Dec 6, 2023

NidhiKJha previously approved these changes Dec 8, 2023

View reviewed changes

vthomas13 previously approved these changes Dec 11, 2023

View reviewed changes

darkwing dismissed stale reviews from vthomas13 and NidhiKJha via 9688179 December 11, 2023 23:17

vthomas13 previously approved these changes Dec 12, 2023

View reviewed changes

darkwing mentioned this pull request Dec 12, 2023

UX: Release showing total account balance #22204

Closed

13 tasks

darkwing dismissed vthomas13’s stale review via dada77d December 12, 2023 20:28

darkwing force-pushed the release-asset-group branch from dada77d to 663ff79 Compare December 12, 2023 20:58

darkwing changed the title ~~UX: Release AvatarGroup for Account Menu~~ UX: Release AvatarGroup for Account Menu, Show Total Account Balances Dec 13, 2023

darkwing changed the title ~~UX: Release AvatarGroup for Account Menu, Show Total Account Balances~~ UX: Show Total Account Balances Dec 13, 2023

darkwing force-pushed the release-asset-group branch 3 times, most recently from d742032 to 277d00c Compare December 19, 2023 20:34

kevinghim assigned NidhiKJha Jan 10, 2024

darkwing commented Jan 10, 2024

View reviewed changes

ui/pages/confirmation/templates/__snapshots__/remove-snap-account.test.js.snap Show resolved Hide resolved

NidhiKJha force-pushed the release-asset-group branch 2 times, most recently from e20ef46 to 6d0707a Compare February 5, 2024 13:01

vthomas13 previously approved these changes Feb 5, 2024

View reviewed changes

NidhiKJha dismissed vthomas13’s stale review via a9c1d0b February 6, 2024 08:03

darkwing added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. and removed needs-ux-ds-review labels Feb 7, 2024

hesterbruikman added the team-core-extension-ux Core Extension UX team label Feb 7, 2024

NidhiKJha added 7 commits February 8, 2024 22:05

e2e fixes

8104299

jest update

5281ce9

updated lint and multichain e2e tests

15197e2

removed unused component

43df45d

added await in send-eth

aa8c399

updated test for multichain

383ea8c

updated test for send

6dcdd50

NidhiKJha force-pushed the release-asset-group branch from 1d28374 to 6dcdd50 Compare February 8, 2024 17:00

updated test

3c71afc

vthomas13 previously approved these changes Feb 8, 2024

View reviewed changes

NidhiKJha previously approved these changes Feb 8, 2024

View reviewed changes

darkwing commented Feb 9, 2024

View reviewed changes

gauthierpetetin removed the team-extension-client label Feb 9, 2024

removed total balance for test net

84ffe7e

NidhiKJha dismissed stale reviews from vthomas13 and themself via 84ffe7e February 13, 2024 08:30

NidhiKJha and others added 6 commits February 13, 2024 17:18

Merge branch 'develop' into release-asset-group

ca8439a

updated test for multichain

015ab59

updated tests

5c1bc77

removed duplicacy

e1c83db

Merge branch 'develop' into release-asset-group

038c11c

mmi prep build fix

2e083a8

NidhiKJha approved these changes Feb 14, 2024

View reviewed changes

vthomas13 approved these changes Feb 14, 2024

View reviewed changes

darkwing merged commit 558f32f into develop Feb 14, 2024

darkwing deleted the release-asset-group branch February 14, 2024 14:48

github-actions bot locked and limited conversation to collaborators Feb 14, 2024

metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UX: Show Total Account Balances #22186

UX: Show Total Account Balances #22186

Uh oh!

darkwing commented Dec 6, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Dec 6, 2023

Uh oh!

metamaskbot commented Dec 6, 2023

Uh oh!

codecov bot commented Dec 6, 2023 •

edited

Loading

Uh oh!

Uh oh!

metamaskbot commented Feb 6, 2024

Uh oh!

metamaskbot commented Feb 8, 2024

Uh oh!

darkwing left a comment

Uh oh!

metamaskbot commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

UX: Show Total Account Balances #22186

UX: Show Total Account Balances #22186

Uh oh!

Conversation

darkwing commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 6, 2023

Uh oh!

metamaskbot commented Dec 6, 2023

Uh oh!

codecov bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

metamaskbot commented Feb 6, 2024

Uh oh!

metamaskbot commented Feb 8, 2024

Uh oh!

darkwing left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

darkwing commented Dec 6, 2023 •

edited

Loading

codecov bot commented Dec 6, 2023 •

edited

Loading