Prevent duplicate changelog entries #10786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
Gudahtt
force-pushed
the
prevent-duplicate-changelog-entries
branch
from
d4a4cf4 to
a52dfa7
Compare
Collaborator
Builds ready [a52dfa7]
Page Load Metrics (576 ± 50 ms)
|
Gudahtt
force-pushed
the
prevent-duplicate-changelog-entries
branch
from
a52dfa7 to
74e6a68
Compare
Collaborator
Builds ready [74e6a68]
Page Load Metrics (610 ± 37 ms)
|
Base automatically changed from
add-changelog-entries-under-correct-header
to
develop
April 1, 2021 14:58
The changelog update script now prevents duplicate entries from being added. Specifically, it will ensure that if a PR has been referenced already in an entry, it will not add it again. This should prevent it from adding duplicate entries for changes that were cherry-picked into hotfix releases. Note that this duplication prevention only works for entries containing a PR number. We don't have any way to prevent duplicate entries yet in cases where we don't know the associated PR. We will be preventing this possibility entirely pretty soon in some upcoming release automation changes though, so I'm not concerned about this omission.
Gudahtt
force-pushed
the
prevent-duplicate-changelog-entries
branch
from
74e6a68 to
2baac2a
Compare
Collaborator
Builds ready [2baac2a]
Page Load Metrics (658 ± 98 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changelog update script now prevents duplicate entries from being added. Specifically, it will ensure that if a PR has been referenced already in an entry, it will not add it again.
This should prevent it from adding duplicate entries for changes that were cherry-picked into hotfix releases.
Note that this duplication prevention only works for entries containing a PR number. We don't have any way to prevent duplicate entries yet in cases where we don't know the associated PR. We will be preventing this possibility entirely pretty soon in some upcoming release automation changes though, so I'm not concerned about this omission.
Relates to #10752
Manual testing steps:
yarn update-changelogyarn update-changelogagain