Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the properties of the objects returned in the swaps /trades api, and how they are modified #9712

Open
danjm opened this issue Oct 25, 2020 · 1 comment
Open

Document the properties of the objects returned in the swaps /trades api, and how they are modified #9712

danjm opened this issue Oct 25, 2020 · 1 comment
Labels
area-swaps type-refactor

Comments

@danjm
Copy link
Contributor

danjm commented Oct 25, 2020

The swaps trades api returns objects with data pertaining to different swaps a user can make. These objects are extended within the swaps controller. We need documentation about the shape of the object when first returned, and how the shape is modified and extended at various points after return. See comments here for further detail / spec: #9599 (comment) and #9599 (comment)
@danjm danjm mentioned this issue Oct 25, 2020
Merged
@jacobc-eth jacobc-eth added area-swaps area-documentation Issues relating to documentation, in the codebase and off. labels Nov 7, 2020
@rekmarks
Copy link
Member

rekmarks commented Jan 7, 2021

Did we make any progress on this @danjm?

@Gudahtt Gudahtt added type-refactor and removed area-documentation Issues relating to documentation, in the codebase and off. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-swaps type-refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Gudahtt @danjm @jacobc-eth @rekmarks