Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for signTypedData_v4 #6868

Closed
danfinlay opened this issue Jul 16, 2019 · 5 comments · Fixed by #6930
Closed

Add support for signTypedData_v4 #6868

danfinlay opened this issue Jul 16, 2019 · 5 comments · Fixed by #6930
Labels
area-provider Relating to the provider module. T08-featureRequest

Comments

@danfinlay
Copy link
Contributor

danfinlay commented Jul 16, 2019

UI should be identical to _v3, making implementation simple. The difference is it should use the newly merged v4 method in eth-sig-util@2.3.0, which supports arrays and recursive structs.

Created by our friends at Infura to support a new type of state channel they've designed!

Completing this issue also requires updating our docs site.

@BrendanChou
Copy link
Contributor

@whymarrh @danfinlay Can you reopen this as the rpc call was not previously supported in eth-json-rpc middleware, so the extension itself still cannot process these calls.

I fix that with a PR here, but metamask-extension will still have to use the new npm version of eth-json-rpc-middleware MetaMask/eth-json-rpc-middleware#15

@danfinlay danfinlay reopened this Sep 4, 2019
@danfinlay
Copy link
Contributor Author

Merged your changed and published it as + eth-json-rpc-middleware@4.2.0

@danfinlay
Copy link
Contributor Author

I'll get to this soon if you don't beat me to it.

@BrendanChou
Copy link
Contributor

Hey Dan, is this going to be in 7.1.2? Should just be updating the eth-json-rpc-middleware package right?

@whymarrh
Copy link
Contributor

whymarrh commented Sep 9, 2019

@BrendanChou this should be out in 7.2.0 very soon, I'm going to bump this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-provider Relating to the provider module. T08-featureRequest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants