Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Queued request controller not working as expected in mmi build #28441

Open
hjetpoluru opened this issue Nov 13, 2024 · 0 comments
Open
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production release-12.7.0 Issue or pull request that will be included in release 12.7.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-api-platform type-bug

Comments

@hjetpoluru
Copy link
Contributor

Describe the bug

I was trying to fix the flaky test for the switchEthereum function, and there is inconsistent behavior where switching to the network does not happen.

Github ticket - #28195
Test Path - /test/e2e/json-rpc/switchEthereumChain.spec.js
Test scenario - Switch Ethereum Chain for two dapps queues switchEthereumChain request from second dapp after send tx request

Thanks to @seaona for mentioning about the defect #27977.
Later, I realized that Alex has made a fix #28371 and linking the Slack discussion in v12.7.0 RC Thread but it requires additional effort for the mmi I build due to the code fence.
Hence, I have created this ticket for tracking purposes.

Expected behavior

No response

Screenshots/Recordings

Screen.Recording.2024-11-13.at.9.40.57.AM.mov

Steps to reproduce

Perquisite: mmi build is needed

  1. Open the extension app and Toggle off the request queue setting.
  2. Open dApp with the Ethereum network
  3. Initiate a send transaction on the dApp.
  4. Switch to dApp to localhost using the switchNetwork command below in console log

await window.ethereum.request({"method":"wallet_switchEthereumChain",params: [{ chainId: '0x539' }],})
5. In the send transaction, switch and confirm the queued notification for switchEthereumChain.

Error messages or log output

No response

Detection stage

On the development branch

Version

12.7.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@hjetpoluru hjetpoluru added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-api-platform labels Nov 13, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 13, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 13, 2024
@hjetpoluru hjetpoluru added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Nov 13, 2024
@metamaskbot metamaskbot added the regression-develop Regression bug that was found on development branch, but not yet present in production label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production release-12.7.0 Issue or pull request that will be included in release 12.7.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-api-platform type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants