Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Transactions - Sending a tx with higher nonce makes the tx remain with status Signed and blocks the wallet for sending tx's in all networks #27824

Open
seaona opened this issue Oct 14, 2024 · 1 comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Oct 14, 2024

Describe the bug

When I try to send a transaction with a higher nonce than the suggested one, using a local network (ganache) I see that the transaction remains in a Signed status and MM loading.
If I refresh and I try to send a transaction I cannot do it since I see the error A previous transaction is still being signed or submitted. After that, even if I change networks and try to send a transaction in a different network I see the same error and the wallet is stuck. For this reason I added a sev1 label, as there is no way of getting out of this state, unless you terminate the local network (this might not be an option to the users if this happens with a network they are not controlling)

This explains the behaviour I was seeing here: #27561 (comment) combined with another bug, where the nonce is not updated after switching networks (I'm currently trying to find repro steps for this one).

Smart transactions are disabled.

Expected behavior

In 12.3.1, this Signed transaction is discarded once we switch networks, unblocking the wallet from this state. Should we aim something similar?

Screenshots/Recordings

nonce-signed-block-wallet.mp4

See how in 12.3.1, this Signed transaction is discarded after switching networks, unblocking the wallet from this state and allowing to perform transactions in different networks.

signed-tx-stuck-12.3.1-behaviour.mp4

Steps to reproduce

  1. Run ganache in a local server
  2. Import localhost
  3. Start a transaction
  4. Customize the nonce to a higher value than expected
  5. Confirm
  6. See how MM stays loading and transaction remains in Signed state
  7. Refresh
  8. Switch networks
  9. Try to send a tx on another network
  10. See it's not possible as you get the error A previous transaction is still being signed or submitted

Error messages or log output

No response

Detection stage

In production (default)

Version

12.4.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@seaona seaona added type-bug Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team team-transactions Transactions team labels Oct 14, 2024
@seaona seaona changed the title [Bug]: Transactions - A Transaction remains with status Signed and blocks the wallet when the nonce is higher than expected [Bug]: Transactions - Sending a tx with higher nonce makes the tx remain with status Signed and blocks the wallet for sending tx's in all networks Oct 14, 2024
@metamaskbot metamaskbot added the regression-prod-12.4.0 Regression bug that was found in production in release 12.4.0 label Oct 14, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Oct 14, 2024

The "infinite load after submitting a higher nonce on Ganache/localhost" issue shown in both before and after cases is covered by this separate bug: #21259

@bschorchit bschorchit removed the team-transactions Transactions team label Oct 14, 2024
@matthewwalsh0 matthewwalsh0 added Sev2-normal Normal severity; minor loss of service or inconvenience. and removed Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. regression-prod-12.4.0 Regression bug that was found in production in release 12.4.0 labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

5 participants