[Bug]: Huge number of accounts generated within the wallet when utilizing development builds ('Profile sync' is ON)

[sleepytanya]

Describe the bug

Slack discussion link https://consensys.slack.com/archives/CBHSSFEN5/p1727135446963979

Big number of accounts generated within the wallet on development builds leading to a noticeable decrease in performance, rendering the wallet unusable.

"With profile sync on, the builds using develop will indeed either:
save the accounts info to the user storage if it never happened before
retrieve accounts from user storage if present, and add new accounts until we locally reach the same length as present in user storage "( thank you, Mathieu!)

Not sure this is in the scope of this ticket but this is 'broken' account https://sepolia.etherscan.io/address/0xA24B5c474dF517b083811b099054D670Ba696C7a
Last transaction created with the nonce 2102, while previous transaction nonce is 325.

Expected behavior

Screenshots/Recordings

100+ accounts - recording is redacted, the onboarding took ~ 4 mins:

hundredAccounts.mov

Same number of accounts (117) both in the UI and in the JSON response (hashedkKey):

Screen.Recording.2024-09-25.at.10.00.03.mov

Steps to reproduce

1. Set Settings -> Security & Privacy -> Privacy -> Profile sync ON

Error messages or log output

No response

Detection stage

On the development branch

Version

12.2.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

[sleepytanya]

Encountered the same issue with another wallet on the latest develop again, extension is stuck on loading screen, new error message:

On the latest develop every time account is imported the amount of accounts is higher (almost two times higher).