Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Redesign Confirmation Responsive Behavior #27115

Open
digiwand opened this issue Sep 12, 2024 · 0 comments
Open

Fix Redesign Confirmation Responsive Behavior #27115

digiwand opened this issue Sep 12, 2024 · 0 comments
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production team-confirmations Push issues to confirmations team type-enhancement

Comments

@digiwand
Copy link
Contributor

Describe the bug

Based on the Figma design, we will update the redesign confirmation responsive behavior.

Spec:

  • Update max-width (current 360px for all screens)
    • 1440 x 900 screen: 600px
    • 1024 x 674 screen: 425px
  • Make header and footer sticky
    • padding above and below: 32px

Previous Related Issue: #26937
Previoius Related PR: #26965

Expected behavior

No response

Screenshots/Recordings

CleanShot 2024-09-12 at 20 20 32@2x
CleanShot 2024-09-06 at 12 11 35@2x
CleanShot 2024-09-06 at 12 12 25@2x
CleanShot 2024-09-06 at 12 13 09@2x
CleanShot 2024-09-06 at 12 13 59@2x
CleanShot 2024-09-06 at 15 35 13@2x

Steps to reproduce

  1. Turn on Improved Signature / Transaction Requests
  2. Observe confirmation pages

Error messages or log output

No response

Detection stage

On the development branch

Version

12.4.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@digiwand digiwand added type-bug team-confirmations Push issues to confirmations team labels Sep 12, 2024
@metamaskbot metamaskbot added the regression-develop Regression bug that was found on development branch, but not yet present in production label Sep 12, 2024
@OGPoyraz OGPoyraz changed the title [Bug]: Fix Redesign Confirmation Responsive Behavior Fix Redesign Confirmation Responsive Behavior Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production team-confirmations Push issues to confirmations team type-enhancement
Projects
Bugs by severity
Status: To be fixed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OGPoyraz @digiwand @metamaskbot