Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect warning message shown when there is an insufficient balance for a swap, errors in the console #26341

Open
sleepytanya opened this issue Aug 5, 2024 · 0 comments
Labels
regression-prod-11.16.16 Regression bug that was found in production in release 11.16.16 Sev2-normal Normal severity; minor loss of service or inconvenience. team-swaps type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Aug 5, 2024

Describe the bug

When there is an insufficient balance for a swap, users encounter a misleading warning message stating "No quotes available," instead of a more accurate indication of the balance issue.
This issue arises because the amount does not automatically reset to zero when a user selects a different token, leading to an insufficient balance problem.

Expected behavior

The amount should automatically reset to zero whenever a token is switched and correct warning message should be displayed, to ensure clarity and prevent any balance discrepancies.

Screenshots/Recordings

noQuotesv11.mov
Screenshot 2024-08-05 at 01 23 30
noQuotesFirefox.mov

Correct 'Insufficient balance' message that should be displayed:

Screenshot 2024-08-05 at 01 32 46

Steps to reproduce

  1. Start swap for any token, choose amount
  2. Switch to the token with a smaller balance than selected amount

Error messages or log output

No response

Detection stage

In production (default)

Version

v11.16.16, v12.0.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug team-swaps regression-prod-11.16.16 Regression bug that was found in production in release 11.16.16 labels Aug 5, 2024
@desi desi added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-11.16.16 Regression bug that was found in production in release 11.16.16 Sev2-normal Normal severity; minor loss of service or inconvenience. team-swaps type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants