Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Errors in the console when enabling notifications for an account #26068

Open
sleepytanya opened this issue Jul 24, 2024 · 3 comments
Open
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production Sev2-normal Normal severity; minor loss of service or inconvenience. team-notifications Notifications team type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

Every time when user enables notifications for the account there are errors in the console.

Develop:

develop.mov
Screenshot 2024-07-23 at 15 51 38

Latest v12.0.0 build and beta - only 'Uncaught' errors:

latest12.mov
Screen.Recording.2024-07-23.at.20.44.36.mov

Expected behavior

Screenshots/Recordings

No response

Steps to reproduce

  1. Go to Notifications
  2. Disable / Enable notification for account

Error messages or log output

No response

Detection stage

On the development branch

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug team-notifications Notifications team regression-develop Regression bug that was found on development branch, but not yet present in production regression-RC-12.0.0 labels Jul 24, 2024
@Prithpal-Sooriya
Copy link
Contributor

Related: #25750

The recent changes have made push notifications optional (so still creates notifications, but will silently fail push notifications). What we see here are some logs to inform us that push notifications have failed.

We want these errors to be visible in sentry. Maybe we can change from error logs to warning logs.

We can mark this as low severity and resolve in a future version (12.1)

@gauthierpetetin gauthierpetetin added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Jul 25, 2024
@sleepytanya
Copy link
Contributor Author

Prod v12.1.0

Every time user disables notifications for the selected account there is an error:

Screenshot 2024-08-09 at 17 22 39
uncaught.mov

@Prithpal-Sooriya
Copy link
Contributor

Noted. These error logs are valid (we may make these silent in future versions).

Our team will investigate.

There is a known bug on push notifications with our API.

This impact is on push notifications. It will not impact showing notifications, or modifying settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production Sev2-normal Normal severity; minor loss of service or inconvenience. team-notifications Notifications team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

4 participants