Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement automated check to detect unintended increase in network request volume #25966

Open
9 tasks
chloeYue opened this issue Jul 19, 2024 · 0 comments
Open
9 tasks
Labels
area-qa Relating to QA work (Quality Assurance) team-extension-platform

Comments

@chloeYue
Copy link
Contributor

chloeYue commented Jul 19, 2024

What is this about?

We've identified a release-blocking issue where a periodic polling task continues to run every 20 seconds, even after the UI is closed. This results in generating a big amount of unnecessary API request to Etherscan and to the RPC provider:

API request to Etherscan:
https://api.etherscan.io/api?

3 to RPC provider:

"jsonrpc":"2.0","method":"eth_blockNumber",
"jsonrpc":"2.0","method":"eth_getBlockByNumber"
jsonrpc":"2.0","method":"eth_call","params":

The objective of this ticket is to introduce an automated check that monitors for unintended increases in the volume of network requests. For example, the test can establish a threshold for network requests and trigger an alert if a significant increase is detected.

Slack discussion: https://consensys.slack.com/archives/C07CGH75GFN/p1721233816417369
Related PR attempt to fix this issue: #25909
Associated Ticket for Adding Manual Scenario: #25964

This automated check will serve as an early warning system to prevent potential performance issues or unnecessary load on external services, ensuring our application maintains optimal efficiency and resource usage.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@chloeYue chloeYue changed the title Add automated test to catch unattended increase volume of requests Implement automated test to detect unintended increase in network request volume Jul 19, 2024
@chloeYue chloeYue changed the title Implement automated test to detect unintended increase in network request volume Implement automated check to detect unintended increase in network request volume Jul 19, 2024
@chloeYue chloeYue added the area-qa Relating to QA work (Quality Assurance) label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-qa Relating to QA work (Quality Assurance) team-extension-platform
Projects
None yet
Development

No branches or pull requests

1 participant