Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_call requests for balances from the account tracker can occur even if the associated privacy setting is toggled off #25953

Open
danjm opened this issue Jul 18, 2024 · 1 comment
Labels
Sev3-low Low severity; minimal to no impact upon users team-extension-platform type-bug

Comments

@danjm
Copy link
Contributor

danjm commented Jul 18, 2024

The updateAccountsViaBalanceChecker method in the account tracker, and therefore the eth_call to the SINGLE_CALL_BALANCES_ADDRESSES, is happening even if the associated privacy setting ("Batch account balance requests") is toggled off.

This exists on 11.16.14, and probably earlier, although I have not yet determined how much earlier.

@danjm danjm added type-bug release-blocker This bug is blocking the next release regression-beta-12.0.0 Regression bug that was found in beta in release 12.0.0 labels Jul 18, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jul 18, 2024
@danjm danjm added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. and removed release-blocker This bug is blocking the next release regression-beta-12.0.0 Regression bug that was found in beta in release 12.0.0 labels Jul 22, 2024
@NiranjanaBinoy NiranjanaBinoy self-assigned this Aug 15, 2024
@Gudahtt Gudahtt added Sev3-low Low severity; minimal to no impact upon users and removed Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. labels Aug 15, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Aug 15, 2024

Downgrading to sev3 because the balance update contract is still only being called with a single account at a time.

We can still update this to check the single account's balance directly, rather than through the contract. Maybe saving Infura some money and improving performance a little bit. But the problem shouldn't have any significant user impact or privacy impact.

@NiranjanaBinoy NiranjanaBinoy removed their assignment Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev3-low Low severity; minimal to no impact upon users team-extension-platform type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

5 participants