Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Improve the responsive logic and its documentation for testing small window size #25935

Open
9 tasks
seaona opened this issue Jul 18, 2024 · 0 comments
Open
9 tasks
Labels
area-qa Relating to QA work (Quality Assurance) team-extension-platform

Comments

@seaona
Copy link
Contributor

seaona commented Jul 18, 2024

What is this about?

From @Gudahtt,

  • Convert the drivers to TypeScript, and use a shared type so that it's clearer they should be shared
  • Add a JSDoc comment explaining what these options are for
  • Add a JSDoc comment to the buildBrowserWebDriver function in test/e2e/webdriver/index.js to document these shared options, and explain what they are for
  • Replace responsive with a viewport option to specify desired width and height, and conditionally decide when to use the devtools hack within the Chrome driver
  • Find an alternative solution to reducing the viewport (e.g. open the extension in an iframe within another extension page)

In this PR, the responsive functionality was restored after being broken: #25932

Thread for more context: https://consensys.slack.com/archives/CTQAGKY5V/p1721256441247509

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@seaona seaona added team-extension-platform area-qa Relating to QA work (Quality Assurance) labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-qa Relating to QA work (Quality Assurance) team-extension-platform
Projects
None yet
Development

No branches or pull requests

1 participant