You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Convert the drivers to TypeScript, and use a shared type so that it's clearer they should be shared
Add a JSDoc comment explaining what these options are for
Add a JSDoc comment to the buildBrowserWebDriver function in test/e2e/webdriver/index.js to document these shared options, and explain what they are for
Replace responsive with a viewport option to specify desired width and height, and conditionally decide when to use the devtools hack within the Chrome driver
Find an alternative solution to reducing the viewport (e.g. open the extension in an iframe within another extension page)
In this PR, the responsive functionality was restored after being broken: #25932
Stakeholder review needed before the work gets merged
Engineering (needed in most cases)
Design
Product
QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
Security
Legal
Marketing
Management (please specify)
Other (please specify)
References
No response
The text was updated successfully, but these errors were encountered:
What is this about?
From @Gudahtt,
In this PR, the responsive functionality was restored after being broken: #25932
Thread for more context: https://consensys.slack.com/archives/CTQAGKY5V/p1721256441247509
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: