Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: MetaMask displays error messages across various screens #25838

Open
sleepytanya opened this issue Jul 15, 2024 · 2 comments
Open

[Bug]: MetaMask displays error messages across various screens #25838

sleepytanya opened this issue Jul 15, 2024 · 2 comments
Assignees
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production regression-prod-11.16.14 Regression bug that was found in production in release 11.16.14 Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Jul 15, 2024

Describe the bug

Occasionally, MetaMask users may notice error messages appearing across various screens, floating above the interface in a random manner. These errors primarily observed within the Settings section, though they have also made appearances on other screens. I'll make sure to update this ticket with more detailed information as it becomes available.

Expected behavior

Errors should be displayed in a predictable sequence, either within the console or as predefined error messages, to ensure clarity and ease of troubleshooting for users.

Screenshots/Recordings

Screenshot 2024-07-15 at 14 51 43 Screenshot 2024-07-15 at 14 52 30 Screenshot 2024-07-15 at 14 52 03

Steps to reproduce

  1. Once you see any error, check if there is a error message within the Settings (or other screens)

Error messages or log output

No response

Version

11.6.0, 11.16.0, 12.0.0, 12.1.0, develop

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug regression-RC-12.0.0 regression-prod-11.16.14 Regression bug that was found in production in release 11.16.14 regression-RC-12.1.0 regression-develop Regression bug that was found on development branch, but not yet present in production labels Jul 15, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Jul 18, 2024

The displayWarning function in actions.ts is responsible for this. This function is deprecated; replacing remaining usages will resolve this problem.

Though we'll have to find a more appropriate way to display each error on a case-by-case basis.

@gauthierpetetin
Copy link
Contributor

We've reviewed this issue during refinement with @MetaMask/extension-platform . It seems the next step is clear as indicated by Gudahtt: remove occurrences of displayWarning function from the entire codebase. Changing the status to "ready for dev" to reflect that.

@vthomas13 vthomas13 self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production regression-prod-11.16.14 Regression bug that was found in production in release 11.16.14 Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

5 participants