Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Send - ENS resolution displays different address length previews #25286

Open
seaona opened this issue Jun 13, 2024 · 2 comments
Open

[Bug]: Send - ENS resolution displays different address length previews #25286

seaona opened this issue Jun 13, 2024 · 2 comments
Labels
area-send Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale team-snaps-platform Snaps Platform team type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Jun 13, 2024

Describe the bug

Whenever we are sending to an ENS address, we can see how the first address preview displays

  • 0x1111...1111
    but once we click, the second address preview displays:
  • 0x11111...11111

This issue was introduced by this PR.

Expected behavior

We should consolidate the 2 and display the same preview address length

Screenshots/Recordings

ens-resolve-address-length-missmatch.mp4

Steps to reproduce

  1. Start a Send
  2. Add recipient ie vitalik.eth
  3. See preview address length
  4. Click on recipient
  5. See preview address length is different (longer)

Error messages or log output

No response

Version

develop (not in prod yet)

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@seaona seaona added type-bug Sev3-low Low severity; minimal to no impact upon users area-send labels Jun 13, 2024
@desi desi added the team-snaps-platform Snaps Platform team label Jun 13, 2024
@desi
Copy link

desi commented Jun 13, 2024

Hi Snaps team, we assigned this bug to you because we believe the PR that triggered the error was from your team. If we are incorrect please feel free to assign back to us or if you know who it should be assigned to, feel free to add that teams label.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-send Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale team-snaps-platform Snaps Platform team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants