Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Contract revert error messages are too vague #23638

Open
jxom opened this issue Mar 22, 2024 · 1 comment
Open

[Bug]: Contract revert error messages are too vague #23638

jxom opened this issue Mar 22, 2024 · 1 comment
Labels
external-contributor T08-featureRequest team-confirmations Push issues to confirmations team type-enhancement

Comments

@jxom
Copy link

jxom commented Mar 22, 2024

Describe the bug

When a contract interaction is expected to revert, I would expect the primary action to be disabled and a proper error message (from revert data) to be displayed (for this case "Token ID is taken").

CleanShot 2024-03-22 at 13 09 48@2x

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

Can repro by performing mint(69) on https://etherscan.io/address/0xFBA3912Ca04dd458c843e2EE08967fC04f3579c2#writeContract.

Error messages or log output

No response

Version

Latest

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@jxom jxom added the type-bug label Mar 22, 2024
@anaamolnar anaamolnar added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-enhancement labels Mar 26, 2024
@anaamolnar
Copy link

Hello, @jxom. Thanks for reporting! I will pass this feedback on to the team.

@bschorchit bschorchit added T08-featureRequest Sev3-low Low severity; minimal to no impact upon users labels Mar 27, 2024
@cryptotavares cryptotavares removed type-bug Sev3-low Low severity; minimal to no impact upon users labels Mar 28, 2024
@cryptotavares cryptotavares added team-confirmations Push issues to confirmations team team-transactions Transactions team and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-system DEPRECATED: please use "team-confirmations" label instead team-confirmations Push issues to confirmations team labels Apr 24, 2024
@dbrans dbrans added team-confirmations Push issues to confirmations team and removed team-transactions Transactions team labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external-contributor T08-featureRequest team-confirmations Push issues to confirmations team type-enhancement
Projects
Bugs by severity
Status: To be fixed
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dbrans @jxom @cryptotavares @bschorchit @metamaskbot @anaamolnar