Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iconUrls from add-ethereum-chain to populate network icons #20679

Open
kevinghim opened this issue Aug 31, 2023 · 1 comment
Open

Use iconUrls from add-ethereum-chain to populate network icons #20679

kevinghim opened this issue Aug 31, 2023 · 1 comment
Labels
product-backlog team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead

Comments

@kevinghim
Copy link
Contributor

kevinghim commented Aug 31, 2023

Background

We don't currently have a decentralized way to make changes to network metadata such as network name and icons. We frequently get requests to add or change icons -- we should consider making the chain logo part of the add-ethereum-chain api, and also the custom network form. https://github.com/ethereum-lists/chains already allowing PRs to specify icons for chains added to the DB, so whenever a network has a request to update metadata, we'll point them to make changes there.

Acceptance criteria

  • store iconUrls passed in from the add-ethereum-chain api are stored as part of the network configuration
  • wallet should save the image on its first request
  • cache it locally (to reduce IP trackability)
  • create a field on the custom network form for users to
  • provide a UI to give users control when there are multiple RPCs with the same chainId [optional]
@kevinghim kevinghim added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Aug 31, 2023
@kevinghim kevinghim changed the title Use iconUrls from add-ethereum-chain to populate network icons Use iconUrls from add-ethereum-chain to populate network icons Aug 31, 2023
@kevinghim kevinghim changed the title Use iconUrls from add-ethereum-chain to populate network icons Use iconUrls from add-ethereum-chain to populate network icons Aug 31, 2023
@marianoangra
Copy link

E para Polygon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-backlog team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

No branches or pull requests

3 participants