Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test to cover swaps ERC20->ETH flow #17750

Open
danjm opened this issue Feb 14, 2023 · 0 comments
Open

Add e2e test to cover swaps ERC20->ETH flow #17750

danjm opened this issue Feb 14, 2023 · 0 comments
Labels
area-swaps area-testSuite team-swaps

Comments

@danjm
Copy link
Contributor

danjm commented Feb 14, 2023

Ideally, an e2e test would have caught #17717

We should add a test that would have caught that bug in the PR that fixes it or immediately afterwards
@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@pedronfigueiredo pedronfigueiredo removed the stale issues and PRs marked as stale label Jul 20, 2023
@MetaMask MetaMask deleted a comment from github-actions bot Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-swaps area-testSuite team-swaps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danjm @pedronfigueiredo and others