Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete confirm-token-transaction-switch component #17418

Open
jpuri opened this issue Jan 25, 2023 · 0 comments
Open

Delete confirm-token-transaction-switch component #17418

jpuri opened this issue Jan 25, 2023 · 0 comments
Labels
team-confirmations-planning (only for internal use within Confirmations team) type-refactor

Comments

@jpuri
Copy link
Contributor

jpuri commented Jan 25, 2023

Component confirm-token-transaction-switch takes care to get token relates data from using selectors and other hooks and rendering token routes passing this data. We need to do following refactor:

  1. Minimise props passing from confirm-token-transaction-switch. This can be done by getting this data directly in confirm-approve and confirm-token-transaction-base components. Both of these are functional components. Only 1 prop transaction should be required to pass down to various components.

  2. Move the 5 routes mapping to /pages/confirm-transaction.component.js

  3. Add more unit test coverage here /pages/confirm-transaction.test.js for the 5 routes added to it

  4. Delete /pages/confirm-token-transaction-switch.js

@jpuri jpuri added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-refactor labels Jan 25, 2023
@jpuri jpuri changed the title Extract function confirm-transaction-base.component.js/renderGasDetailsItem into separate component Create Feb 14, 2023
@jpuri jpuri changed the title Create Remove confirm-token-transaction-switch Feb 14, 2023
@jpuri jpuri changed the title Remove confirm-token-transaction-switch Delete confirm-token-transaction-switch component Feb 14, 2023
@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations-planning (only for internal use within Confirmations team) type-refactor
Projects
None yet
Development

No branches or pull requests

2 participants