Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete confirm-transaction-switch component #17236

Open
jpuri opened this issue Jan 16, 2023 · 0 comments
Open

Delete confirm-transaction-switch component #17236

jpuri opened this issue Jan 16, 2023 · 0 comments
Labels
team-confirmations-planning (only for internal use within Confirmations team) type-refactor

Comments

@jpuri
Copy link
Contributor

jpuri commented Jan 16, 2023

confirm-transaction-switch components is responsible for checking un-approved transaction / message and redirecting to appropriate confirmation route.

  1. Create a util method which will take transaction and return the pathname for confirmation route. Add test coverage for this method.

  2. use this method in /pages/confirm-transaction.component to redirect to specific confirmation route.

  3. Ensure this logic to get transaction id from url is also copied over to /pages/confirm-transaction.component

  4. Copy over test cases from pages/confirm-transaction-switch to /pages/confirm-transaction

  5. Delete pages/confirm-transaction-switch

@jpuri jpuri added type-refactor team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Jan 16, 2023
@jpuri jpuri changed the title Refactoring confirm-deploy-contract component Delete confirm-transaction-switch component Feb 14, 2023
@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations-planning (only for internal use within Confirmations team) type-refactor
Projects
None yet
Development

No branches or pull requests

2 participants