Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token listing ehnancements #15819

Open
kevinghim opened this issue Sep 14, 2022 · 1 comment
Open

Token listing ehnancements #15819

kevinghim opened this issue Sep 14, 2022 · 1 comment

Comments

@kevinghim
Copy link
Contributor

Background

  • We have a growing number of issues related to the application generally assuming "one name, one token".
    • Tokens want longer ticker symbols
      • slack thread
      • Github issue
      • We aren't sure these fit in our UI
      • They seem to get cut off in our UI, providing a risk of not representing different tokens adequately to users.
    • Tokens with duplicate symbols are beginning to pile up in our [[eth-contract-metadata]] registry.
  • Those issues are likely to get worse over time
    • With more chains, the number of tokens with similar names will increase.
  • Meanwhile, we are also embracing more user-centric naming, like via [[address display fallback logic]].
  • We have a need to revisit how we show tokens, and highlight to a user why it is called a given name.
    • From our own list
    • From our [[[[CodeFi]] Improved [[token detection]] v2]]
    • From [[token lists]]
    • From [[EIP-747: wallet_watchAsset]]
    • From user-added via the custom token form

Possible acceptance criteria

- Recognized tokens should show the source of their auto-detection
    - Was this an auto-detected [[proposed name]]?
    - Was this drawn from one or more [[token lists]]?
    - Was this added from a particular domain via [[EIP-747: wallet_watchAsset]]?
    - Was this added manually? When?
- Tokens with names that are similar to other known tokens should be indicated as such.
    - Particularly if the new token name is similar to a token the user already has/trusts.
    - What if the token resembles a token in our auto-detection system that the user has never encountered? Do we need to bother the user about that? Possibly not!
- [[eth-contract-metadata]] should be able to have multiple tokens with the same symbol (but maybe not the same name)
    - Maybe we add fields to distinguish them
        - Official website
        - Support email (as [[MyCrypto]] does)
- When tokens are shown, we should show their `name` field (not just the symbol, which is meant to be shorter).
- Possible: When a token is added/detected, allow the user to either [[pet name]] the token or at least add a personal note to that token, which should then be visible any time that token is interacted with. ("Not the real DAI, just my test token.")
- Anywhere long token names are shown, it should be possible for the user to see the full name (even if cut off in preview).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@kevinghim and others