Consolidate duplicate copies of readable-stream

[hilvmason]

[hilvmason]

@FrederikBolding could you please add a description to this issue for the team to look into further?

[FrederikBolding]

@hilvmason I did not create this issue 😅 But I assume the problem is that we have multiple versions of the dependency readable-stream because of other dependencies being version-locked. To reduce bundle size for MV3 it may be useful to consolidate - But that's a guess 😉

[hilvmason]

oh wow! @FrederikBolding so sorry! haha ... very strange, @jpuri and I were going through everything and definitely saw your name ! We were using ZenHub extension.. wonder if something weird is happening with the connection. Many apologies!

[FrederikBolding]

@hilvmason We also use ZenHub on the snaps team, but have many repositories tracked, so I sometimes move issues that are unrelated to our work to a hidden column on our board.

[legobeat]

@hilvmason Extension still has dependencies in some form of all major versions of readable-stream, including a duplicate of v2:

readable-stream@1.1.14   #devDep(via mockhttp)
readable-stream@2.3.3    #dep(via @metamask/post-message-stream)
readable-stream@2.3.7    #dep/devDep(multiple)
readable-stream@3.6.0    #dep/devDep(multiple)
readable-stream@4.3.0    #devDep(via addons-linter)

The direct usage of MetaMask extension is of version 2.3.7.

While we could probably go straight to v4, I'm thinking a good measure would be to consolidate on v3.

Note that browserify depends on readable-stream@^2.0.2 in both currently used v16 and final v17 - I am not sure if this is a complicating factor?

Related:

• deps: readable-stream@2.3.3->3.6.2 post-message-stream#88
  • This dependency stands for the duplicated (due to being pinned) post-message-stream:2.3.3
  • Release proposal: 8.0.0 post-message-stream#111
• deps: readable-stream@^2.3.3->^3.6.2 json-rpc-middleware-stream#55
  • Release proposal: 5.0.0 json-rpc-middleware-stream#60
• devDeps: mockttp@^2.6.0->^3.9.1 #19163
  • Removes devDependency on readable-stream@1

[legobeat]

Hmm, looks like browserify might be a complicating factor:

• Browserify v17 wishlist browserify/browserify#1940
• builtins - provide streams3 via readable-stream@3 browserify/browserify#1938
• multiple stream versions galore browserify/browserify#1999
• inheritance is botched browserify/stream-browserify#25

@kumavis