Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confirmTransaction Redux state for non-transaction confirmations #10470

Open
Gudahtt opened this issue Feb 17, 2021 · 0 comments
Open

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Feb 17, 2021

The confirmTransaction Redux state serves only to store gas configuration during gas confirmation. However, we have many types of confirmations that don't involve gas (signatures, encryption, etc.). We use this same confirmTransaction Redux state for these transactions despite it serving no purpose, which further complicates the confirmation UI.

We should simplify the confirmation UI by refactoring the confirmation components to ensure this state is only used for transactions, where it serves an actual purpose. Any confirmations without gas can derive their state directly from the background state.

See here for more context: #10350 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant