From db2e8be23acd9bbf09ef700f647c1b759b9f2aba Mon Sep 17 00:00:00 2001
From: Mark Stacey <markjstacey@gmail.com>
Date: Fri, 1 Nov 2024 17:42:49 -0230
Subject: [PATCH] chore: Remove obsolete preview build support (#27968)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## **Description**

We had previously configured CI to support installing `@metamask`-
scoped packages from the GitHub npm registry, as we used this registry
for "preview builds" from the core repository in the past. This is no
longer used; we publish preview builds to npm now instead. The obsolete
CI changes have been removed.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27968?quickstart=1)

## **Related issues**

* [Preview build
instructions](https://github.com/MetaMask/core/blob/main/docs/contributing.md#testing-changes-to-packages-with-preview-builds)
([permalink](https://github.com/MetaMask/core/blob/56efd1d13a8873a5abb9bd9880d0576148b9d1e4/docs/contributing.md#testing-changes-to-packages-with-preview-builds))
* Preview build related extension PRs: #16547, #19970, #20096, #20312


## **Manual testing steps**

This is not anticipated to have any functional impact. If it does break
something, it would be the install step, so we can test this by
installing locally (and seeing that the install step succeeded on CI).

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
---
 .circleci/config.yml                      |  2 +-
 .circleci/scripts/install-dependencies.sh | 42 -----------------------
 .yarnrc.yml                               |  8 -----
 3 files changed, 1 insertion(+), 51 deletions(-)
 delete mode 100755 .circleci/scripts/install-dependencies.sh

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 3836d5e4048e..aa13dea93b75 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -444,7 +444,7 @@ jobs:
       - gh/install
       - run:
           name: Install dependencies
-          command: .circleci/scripts/install-dependencies.sh
+          command: yarn --immutable
       - save_cache:
           key: dependency-cache-{{ checksum "/tmp/YARN_VERSION" }}-{{ checksum "yarn.lock" }}
           paths:
diff --git a/.circleci/scripts/install-dependencies.sh b/.circleci/scripts/install-dependencies.sh
deleted file mode 100755
index 35b7a690fa0c..000000000000
--- a/.circleci/scripts/install-dependencies.sh
+++ /dev/null
@@ -1,42 +0,0 @@
-#!/usr/bin/env bash
-
-set -e
-set -o pipefail
-
-IS_NON_FORK_DRAFT='false'
-
-if [[ -n $CIRCLE_PULL_REQUEST ]] && gh auth status
-then
-  PR_NUMBER="${CIRCLE_PULL_REQUEST##*/}"
-  if [ -n "$PR_NUMBER" ]
-  then
-    IS_NON_FORK_DRAFT="$(gh pr view --json isDraft --jq '.isDraft' "$PR_NUMBER")"
-  fi
-fi
-
-# Build query to see whether there are any "preview-like" packages in the manifest
-# A "preview-like" package is a `@metamask`-scoped package with a prerelease version that has no period.
-QUERY='.dependencies + .devDependencies'                            # Get list of all dependencies
-QUERY+=' | with_entries( select(.key | startswith("@metamask") ) )' # filter to @metamask-scoped packages
-QUERY+=' | to_entries[].value'                                      # Get version ranges
-QUERY+=' | select(test("^\\d+\\.\\d+\\.\\d+-[^.]+$"))'              # Get pinned versions where the prerelease part has no "."
-
-# Use `-e` flag so that exit code indicates whether any matches were found
-if jq -e "${QUERY}" < ./package.json
-then
-  echo "Preview builds detected"
-  HAS_PREVIEW_BUILDS='true'
-else
-  echo "No preview builds detected"
-  HAS_PREVIEW_BUILDS='false'
-fi
-
-if [[ $IS_NON_FORK_DRAFT == 'true' && $HAS_PREVIEW_BUILDS == 'true' ]]
-then
-  # Use GitHub registry on draft PRs, allowing the use of preview builds
-  echo "Installing with preview builds"
-  METAMASK_NPM_REGISTRY=https://npm.pkg.github.com yarn --immutable
-else
-  echo "Installing without preview builds"
-  yarn --immutable
-fi
diff --git a/.yarnrc.yml b/.yarnrc.yml
index cc0c959e2722..8e12d8037c6a 100644
--- a/.yarnrc.yml
+++ b/.yarnrc.yml
@@ -119,14 +119,6 @@ npmAuditIgnoreAdvisories:
   - 'react-beautiful-dnd (deprecation)'
   # New package name format for new versions: @ethereumjs/wallet.
   - 'ethereumjs-wallet (deprecation)'
-npmRegistries:
-  'https://npm.pkg.github.com':
-    npmAlwaysAuth: true
-    npmAuthToken: '${GITHUB_PACKAGE_READ_TOKEN-}'
-
-npmScopes:
-  metamask:
-    npmRegistryServer: '${METAMASK_NPM_REGISTRY:-https://registry.yarnpkg.com}'
 
 plugins:
   - path: .yarn/plugins/@yarnpkg/plugin-allow-scripts.cjs