From 855fab545c544071780c4c169071b9f8d363ecc5 Mon Sep 17 00:00:00 2001 From: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com> Date: Tue, 3 Sep 2024 16:47:46 -0400 Subject: [PATCH] updating the requesttype --- .../handlers/log-web3-shim-usage.ts | 15 +++++++-------- .../lib/rpc-method-middleware/handlers/types.ts | 8 ++++++++ 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/app/scripts/lib/rpc-method-middleware/handlers/log-web3-shim-usage.ts b/app/scripts/lib/rpc-method-middleware/handlers/log-web3-shim-usage.ts index 54d5363c1f9c..0af9545964ef 100644 --- a/app/scripts/lib/rpc-method-middleware/handlers/log-web3-shim-usage.ts +++ b/app/scripts/lib/rpc-method-middleware/handlers/log-web3-shim-usage.ts @@ -2,14 +2,13 @@ import type { JsonRpcEngineNextCallback, JsonRpcEngineEndCallback, } from '@metamask/json-rpc-engine'; -import type { - JsonRpcRequest, - JsonRpcParams, - PendingJsonRpcResponse, -} from '@metamask/utils'; +import type { JsonRpcParams, PendingJsonRpcResponse } from '@metamask/utils'; import { OriginString } from '@metamask/permission-controller'; import { MESSAGE_TYPE } from '../../../../../shared/constants/app'; -import { HandlerWrapper } from './types'; +import { + HandlerWrapper, + HandlerRequestType as LogWeb3ShimUsageHandlerRequest, +} from './types'; type LogWeb3ShimUsageOptions = { getWeb3ShimUsageState: (origin: OriginString) => undefined | 1 | 2; @@ -18,7 +17,7 @@ type LogWeb3ShimUsageOptions = { type LogWeb3ShimUsageConstraint = { implementation: ( - req: JsonRpcRequest, + req: LogWeb3ShimUsageHandlerRequest, res: PendingJsonRpcResponse, _next: JsonRpcEngineNextCallback, end: JsonRpcEngineEndCallback, @@ -57,7 +56,7 @@ export default logWeb3ShimUsage; * usage for a particular origin. */ function logWeb3ShimUsageHandler( - req: JsonRpcRequest, + req: LogWeb3ShimUsageHandlerRequest, res: PendingJsonRpcResponse, _next: JsonRpcEngineNextCallback, end: JsonRpcEngineEndCallback, diff --git a/app/scripts/lib/rpc-method-middleware/handlers/types.ts b/app/scripts/lib/rpc-method-middleware/handlers/types.ts index f2ae5a3db51c..ce5898dc5e3a 100644 --- a/app/scripts/lib/rpc-method-middleware/handlers/types.ts +++ b/app/scripts/lib/rpc-method-middleware/handlers/types.ts @@ -1,4 +1,12 @@ +import { OriginString } from '@metamask/permission-controller'; +import { JsonRpcParams, JsonRpcRequest } from '@metamask/utils'; + export type HandlerWrapper = { methodNames: [string] | string[]; hookNames: Record; }; + +export type HandlerRequestType = + Required> & { + origin: OriginString; + };