Confirmation redesign: add message section to personal sign page (#22766)

Author: jpuri

app/_locales/en/messages.json

@@ -99,8 +99,7 @@ exports[`ConfirmInfo should match snapshot 1`] = `
         </p>
       </div>
       <div
-        class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--flex-wrap-wrap mm-box--align-items-center"
-        style="column-gap: 8px;"
+        class="mm-box mm-box--display-flex mm-box--gap-2 mm-box--flex-direction-row mm-box--flex-wrap-wrap mm-box--align-items-center"
       >
         <p
           class="mm-box mm-text mm-text--body-md mm-box--color-text-muted"

ui/pages/confirmations/confirm/mock-data.ts renamed to test/data/confirmations/personal_sign.ts

@@ -13,6 +13,13 @@ const mockRowConfigs: ConfirmInfoRowConfig[] = [
   {
     type: ConfirmInfoRowType.Divider,
   },
+  {
+    label: 'Origin',
+    type: ConfirmInfoRowType.UrlType,
+    rowProps: {
+      address: 'https://metamask.github.io',
+    },
+  },
   {
     label: 'Account',
     type: ConfirmInfoRowType.ValueDouble,

ui/components/app/confirm/info/__snapshots__/info.test.tsx.snap

@@ -15,6 +15,8 @@ import {
   ConfirmInfoRowAddressProps,
   ConfirmInfoRowDivider,
   ConfirmInfoRowProps,
+  ConfirmInfoRowText,
+  ConfirmInfoRowTextProps,
   ConfirmInfoRowUrl,
   ConfirmInfoRowUrlProps,
   ConfirmInfoRowValueDouble,
@@ -25,12 +27,14 @@ import {
 export enum ConfirmInfoRowType {
   Address = 'address',
   Divider = 'divider',
-  ValueDouble = 'value-double',
+  Text = 'text',
   UrlType = 'url',
+  ValueDouble = 'value-double',
 }
 
 type ConfirmInfoTypeProps =
   | ConfirmInfoRowAddressProps
+  | ConfirmInfoRowTextProps
   | ConfirmInfoRowUrlProps
   | ConfirmInfoRowValueDoubleProps;
 
@@ -41,6 +45,9 @@ const TYPE_TO_COMPONENT: Record<ConfirmInfoRowType, any> = {
   [ConfirmInfoRowType.Divider]: () => {
     return <ConfirmInfoRowDivider />;
   },
+  [ConfirmInfoRowType.Text]: ({ text }: ConfirmInfoRowTextProps) => {
+    return <ConfirmInfoRowText text={text} />;
+  },
   [ConfirmInfoRowType.UrlType]: ({ url }: ConfirmInfoRowUrlProps) => {
     return <ConfirmInfoRowUrl url={url} />;
   },

ui/components/app/confirm/info/info.stories.tsx

@@ -3,8 +3,7 @@
 exports[`ConfirmInfoRowUrl renders a URL, protocol, and warning icon when the protocol is "http" 1`] = `
 <div>
   <div
-    class="mm-box mm-box--display-flex mm-box--flex-wrap-wrap mm-box--align-items-center"
-    style="column-gap: 8px;"
+    class="mm-box mm-box--display-flex mm-box--gap-2 mm-box--flex-wrap-wrap mm-box--align-items-center"
   >
     <p
       class="mm-box mm-text mm-text--body-sm mm-box--padding-right-1 mm-box--padding-left-1 mm-box--display-flex mm-box--align-items-center mm-box--color-warning-default mm-box--background-color-warning-muted mm-box--rounded-sm"
@@ -27,8 +26,7 @@ exports[`ConfirmInfoRowUrl renders a URL, protocol, and warning icon when the pr
 exports[`ConfirmInfoRowUrl should match snapshot 1`] = `
 <div>
   <div
-    class="mm-box mm-box--display-flex mm-box--flex-wrap-wrap mm-box--align-items-center"
-    style="column-gap: 8px;"
+    class="mm-box mm-box--display-flex mm-box--gap-2 mm-box--flex-wrap-wrap mm-box--align-items-center"
   >
     <p
       class="mm-box mm-text mm-text--body-md mm-box--color-inherit"

ui/components/app/confirm/info/info.tsx

@@ -1,5 +1,6 @@
 export * from './address';
 export * from './divider';
 export * from './row';
+export * from './text';
 export * from './url';
 export * from './value-double';

ui/components/app/confirm/info/row/__snapshots__/url.test.tsx.snap

@@ -0,0 +1,25 @@
+import React from 'react';
+import { ConfirmInfoRow } from './row';
+import { ConfirmInfoRowText } from './text';
+
+const ConfirmInfoRowTextStory = {
+  title: 'Components/App/Confirm/InfoRowText',
+  component: ConfirmInfoRowText,
+
+  decorators: [
+    (story) => <ConfirmInfoRow label="Message">{story()}</ConfirmInfoRow>,
+  ],
+
+  argTypes: {
+    url: {
+      control: 'text',
+    },
+  },
+};
+
+export const DefaultStory = ({ text }) => <ConfirmInfoRowText text={text} />;
+DefaultStory.args = {
+  text: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.',
+};
+
+export default ConfirmInfoRowTextStory;

ui/components/app/confirm/info/row/index.ts

@@ -0,0 +1,25 @@
+import React from 'react';
+import { Box, Text } from '../../../../component-library';
+import {
+  AlignItems,
+  Display,
+  FlexWrap,
+  TextColor,
+} from '../../../../../helpers/constants/design-system';
+
+export type ConfirmInfoRowTextProps = {
+  text: string;
+};
+
+export const ConfirmInfoRowText = ({ text }: ConfirmInfoRowTextProps) => {
+  return (
+    <Box
+      display={Display.Flex}
+      alignItems={AlignItems.center}
+      flexWrap={FlexWrap.Wrap}
+      gap={2}
+    >
+      <Text color={TextColor.inherit}>{text}</Text>
+    </Box>
+  );
+};

ui/components/app/confirm/info/row/text.stories.tsx

@@ -37,10 +37,7 @@ export const ConfirmInfoRowUrl = ({ url }: ConfirmInfoRowUrlProps) => {
       display={Display.Flex}
       alignItems={AlignItems.center}
       flexWrap={FlexWrap.Wrap}
-      style={{
-        // TODO: Box should support this
-        columnGap: '8px',
-      }}
+      gap={2}
     >
       {isHTTP && (
         <Text