refactor: simplify expiry extraction using extractExpiryToReadableDate utility

- Use extractExpiryToReadableDate from time-utils instead of manual extraction
- Remove UTC zone specification from convertTimestampToReadableDate
- Reduce getExpirationDate function from 26 to 9 lines
- Import GatorPermissionRule type for proper typing

Author: hanzel98

shared/lib/gator-permissions/time-utils.ts

@@ -87,7 +87,7 @@ export function convertAmountPerSecondToAmountPerPeriod(
  * Converts a unix timestamp(in seconds) to a human-readable date format.
  *
  * @param timestamp - The unix timestamp in seconds.
- * @returns The formatted date string in mm/dd/yyyy format in UTC timezone.
+ * @returns The formatted date string in mm/dd/yyyy format in local timezone.
  */
 export const convertTimestampToReadableDate = (timestamp: number): string => {
   if (timestamp === 0) {

ui/components/multichain/pages/gator-permissions/components/review-gator-permission-item.tsx

@@ -37,6 +37,8 @@ import {
   getPeriodFrequencyValueTranslationKey,
   convertAmountPerSecondToAmountPerPeriod,
   getDecimalizedHexValue,
+  extractExpiryToReadableDate,
+  GatorPermissionRule,
 } from '../../../../../../shared/lib/gator-permissions';
 import { PreferredAvatar } from '../../../../app/preferred-avatar';
 import { BackgroundColor } from '../../../../../helpers/constants/design-system';
@@ -160,33 +162,19 @@ export const ReviewGatorPermissionItem = ({
   };
 
   /**
-   * Returns the expiration date from the delegation context
+   * Returns the expiration date from the permission rules
    *
    * @returns The expiration date
    */
   const getExpirationDate = useCallback((): string => {
-    // Check if rules exist in the permission response
-    if ('rules' in permissionResponse) {
-      const { rules } = permissionResponse;
-
-      if (rules && Array.isArray(rules)) {
-        const expiryRule = rules.find(
-          (rule: { type: string }) => rule.type === 'expiry',
-        );
-
-        if (
-          expiryRule &&
-          'data' in expiryRule &&
-          expiryRule.data &&
-          typeof expiryRule.data === 'object' &&
-          'timestamp' in expiryRule.data
-        ) {
-          const { timestamp } = expiryRule.data;
-          return convertTimestampToReadableDate(timestamp as number);
-        }
+    if ('rules' in permissionResponse && permissionResponse.rules) {
+      const expiryDate = extractExpiryToReadableDate(
+        permissionResponse.rules as GatorPermissionRule[],
+      );
+      if (expiryDate) {
+        return expiryDate;
       }
     }
-
     return t('gatorPermissionNoExpiration');
   }, [permissionResponse, t]);