Bump @metamask/rpc-errors from 5.0.0 to 5.1.1

[dependabot]

Bumps @metamask/rpc-errors from 5.0.0 to 5.1.1.

Release notes

Sourced from @​metamask/rpc-errors's releases.

5.1.1

Fixed

• Allow passing unknown values as cause (#91)
  • Prevously, only Error instances were allowed, but any value can be thrown as error

5.1.0

Added

• Allow passing a cause to predefined error functions (#83)
  • This allows passing an Error instance as cause, by using { data: { cause: /* some error */ } }
  • The error will be properly serialised when calling serialize

Changelog

Sourced from @​metamask/rpc-errors's changelog.

[5.1.1]

Fixed

• Allow passing unknown values as cause (#91)
  • Prevously, only Error instances were allowed, but any value can be thrown as error

[5.1.0]

Added

• Allow passing a cause to predefined error functions (#83)
  • This allows passing an Error instance as cause, by using { data: { cause: /* some error */ } }
  • The error will be properly serialised when calling serialize

Commits

• af3ef43 5.1.1 (#92)
• e06f8d8 Allow passing unknown values as cause (#91)
• 1d1852d 5.1.0 (#90)
• a388854 Bump @​metamask/utils from 5.0.0 to 5.0.1 (#85)
• a324a7a Bump ESLint configs and dependencies to latest version (#89)
• 23c4857 Bump @​metamask/eslint-config-jest from 10.0.0 to 11.1.0 (#88)
• 90024f9 Standardise workflows per the module template as of April 2023 (#82)
• e6a9162 Allow passing a cause to predefined error functions (#83)
• See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[legobeat]

Looks like types need some updates: https://github.com/MetaMask/json-rpc-engine/actions/runs/4751421966/jobs/8448051639#step:5:8

FAIL src/JsonRpcEngine.test.ts
  ● Test suite failed to run

    src/JsonRpcEngine.test.ts:287:7 - error TS2322: Type 'JsonRpcError<DataWithOptionalCause>' is not assignable to type '{ code: number; message: string; data?: Json | undefined; stack?: string | undefined; }'.
      Types of property 'data' are incompatible.
        Type 'DataWithOptionalCause' is not assignable to type 'Json | undefined'.
          Type '{ [key: string]: unknown; cause: unknown; }' is not assignable to type 'Json | undefined'.
            Type '{ [key: string]: unknown; cause: unknown; }' is missing the following properties from type 'Json[]': length, pop, push, concat, and 29 more.

    287       response.error = rpcErrors.internal({ message: 'foobar' });
              ~~~~~~~~~~~~~~
    src/JsonRpcEngine.test.ts:308:7 - error TS2322: Type 'JsonRpcError<DataWithOptionalCause>' is not assignable to type '{ code: number; message: string; data?: Json | undefined; stack?: string | undefined; }'.

    308       response.error = rpcErrors.internal({ message: 'foobar' });
              ~~~~~~~~~~~~~~
    src/JsonRpcEngine.test.ts:370:9 - error TS2322: Type 'JsonRpcError<DataWithOptionalCause>' is not assignable to type '{ code: number; message: string; data?: Json | undefined; stack?: string | undefined; }'.

    370         response.error = rpcErrors.internal({ message: 'foobar' });
                ~~~~~~~~~~~~~~
    src/JsonRpcEngine.test.ts:405:9 - error TS2322: Type 'JsonRpcError<DataWithOptionalCause>' is not assignable to type '{ code: number; message: string; data?: Json | undefined; stack?: string | undefined; }'.

    405         response.error = rpcErrors.internal({ message: 'foobar' });
                ~~~~~~~~~~~~~~

PASS src/asMiddleware.test.ts
PASS src/mergeMiddleware.test.ts
PASS src/createAsyncMiddleware.test.ts
PASS src/idRemapMiddleware.test.ts
FAIL src/createScaffoldMiddleware.test.ts
  ● Test suite failed to run

    src/createScaffoldMiddleware.test.ts:25:9 - error TS2322: Type 'JsonRpcError<DataWithOptionalCause>' is not assignable to type '{ code: number; message: string; data?: Json | undefined; stack?: string | undefined; }'.
      Types of property 'data' are incompatible.
        Type 'DataWithOptionalCause' is not assignable to type 'Json | undefined'.
          Type '{ [key: string]: unknown; cause: unknown; }' is not assignable to type 'Json | undefined'.
            Type '{ [key: string]: unknown; cause: unknown; }' is missing the following properties from type 'Json[]': length, pop, push, concat, and 29 more.

    25         response.error = rpcErrors.internal({ message: 'method3' });
               ~~~~~~~~~~~~~~

[legobeat]

@Mrtenz @FrederikBolding Does this look right to you? Had to add this to make the type pass.

It seems like it should be OK to keep passing unset data here? I don't get exactly how data gets required to fit into Json[], or if the change should be done in @metamask/utils or @metamask/rpc-errors, since I take this as mismatch between the two.

[legobeat]

@Mrtenz @FrederikBolding

[legobeat]

Awaiting answer to https://github.com/MetaMask/json-rpc-engine/pull/147/files#diff-a043cb929a169c41d290c89e2340546eba8dff39ccac2f60b6e69d19f3321743

[legobeat]

@dependabot recreate

[legobeat]

@dependabot close

and reopen for https://github.com/MetaMask/rpc-errors/releases/tag/v6.0.0