Fix default options assignment in getJsonRpcIdValidator

Author: rekmarks

src/utils.ts

@@ -32,11 +32,17 @@ export function isJsonRpcFailure(
 }
 
 interface JsonRpcValidatorOptions {
-  permitEmptyString: boolean;
-  permitFractions: boolean;
-  permitNull: boolean;
+  permitEmptyString?: boolean;
+  permitFractions?: boolean;
+  permitNull?: boolean;
 }
 
+const DEFAULT_VALIDATOR_OPTIONS: JsonRpcValidatorOptions = {
+  permitEmptyString: true,
+  permitFractions: false,
+  permitNull: true,
+};
+
 /**
  * Gets a function for validating JSON-RPC request / response `id` values.
  *
@@ -60,14 +66,11 @@ interface JsonRpcValidatorOptions {
  * Default: `true`
  * @returns The JSON-RPC ID validator function.
  */
-export function getJsonRpcIdValidator(
-  options: JsonRpcValidatorOptions = {
-    permitEmptyString: true,
-    permitFractions: false,
-    permitNull: true,
-  },
-) {
-  const { permitEmptyString, permitFractions, permitNull } = options;
+export function getJsonRpcIdValidator(options?: JsonRpcValidatorOptions) {
+  const { permitEmptyString, permitFractions, permitNull } = {
+    ...DEFAULT_VALIDATOR_OPTIONS,
+    ...options,
+  };
 
   /**
    * @param id - The JSON-RPC ID value to check.

test/utils.test.js

@@ -71,8 +71,6 @@ describe('getJsonRpcIdValidator', function () {
     validateAll(
       getJsonRpcIdValidator({
         permitEmptyString: false,
-        permitFractions: false,
-        permitNull: true,
       }),
       inputs,
     );
@@ -84,9 +82,7 @@ describe('getJsonRpcIdValidator', function () {
 
     validateAll(
       getJsonRpcIdValidator({
-        permitEmptyString: true,
         permitFractions: true,
-        permitNull: true,
       }),
       inputs,
     );
@@ -98,8 +94,6 @@ describe('getJsonRpcIdValidator', function () {
 
     validateAll(
       getJsonRpcIdValidator({
-        permitEmptyString: true,
-        permitFractions: false,
         permitNull: false,
       }),
       inputs,