Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

Commit 2cdd922

Browse files
authored
Repo standardization (#86)
* Enforcing minimum node version 12 via .nvmrc, circleci, and the package file * Adding a note about running tests to README.md * Adding basic .gitattributes file
1 parent 3e8b71c commit 2cdd922

File tree

5 files changed

+22
-7
lines changed

5 files changed

+22
-7
lines changed

.circleci/config.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ workflows:
2222
jobs:
2323
prep-deps:
2424
docker:
25-
- image: circleci/node:10
25+
- image: circleci/node:12
2626
steps:
2727
- checkout
2828
- run:
@@ -41,7 +41,7 @@ jobs:
4141

4242
test-lint:
4343
docker:
44-
- image: circleci/node:10
44+
- image: circleci/node:12
4545
steps:
4646
- checkout
4747
- attach_workspace:
@@ -52,7 +52,7 @@ jobs:
5252

5353
prep-build:
5454
docker:
55-
- image: circleci/node:10
55+
- image: circleci/node:12
5656
steps:
5757
- checkout
5858
- attach_workspace:
@@ -67,7 +67,7 @@ jobs:
6767

6868
test-unit:
6969
docker:
70-
- image: circleci/node:10
70+
- image: circleci/node:12
7171
steps:
7272
- checkout
7373
- attach_workspace:
@@ -78,7 +78,7 @@ jobs:
7878

7979
all-tests-pass:
8080
docker:
81-
- image: circleci/node:10
81+
- image: circleci/node:12
8282
steps:
8383
- run:
8484
name: All tests passed

.gitattributes

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
* text=auto
2+
3+
yarn.lock linguist-generated=false

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v10
1+
v12

README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,3 +143,15 @@ engine.push(function(req, res, next, end){
143143
next() /* This will cause end(res.error) to be called. */
144144
})
145145
```
146+
147+
## Running tests
148+
149+
Build the project if not already built:
150+
151+
```bash
152+
yarn build
153+
```
154+
155+
```bash
156+
yarn test
157+
```

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"author": "kumavis",
77
"main": "dist/index.js",
88
"engines": {
9-
"node": ">=10.0.0"
9+
"node": ">=12.0.0"
1010
},
1111
"files": [
1212
"dist"

0 commit comments

Comments
 (0)