Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subpath exports #214

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Add subpath exports #214

merged 2 commits into from
Sep 21, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 21, 2021

Subpath exports have been added for the three "main" modules in this package. These allow consumers to easily omit the parts of the package they aren't using, without risking accidentally relying upon internal APIs.

The three main "feature" modules have been exposed as subpath exports. The "util" module is the only one not exported, and that's because its API includes methods that we don't want to include in the public API of the package. We can separate the internal and external "util" methods later on if there is any demand for this.

@Gudahtt Gudahtt requested a review from a team as a code owner September 21, 2021 14:52
Subpath exports have been added for the three "main" modules in this
package. These allow consumers to easily omit the parts of the package
they aren't using, without risking accidentally relying upon internal
APIs.

The three main "feature" modules have been exposed as subpath exports.
The "util" module is the only one not exported, and that's because its
API includes methods that we don't want to include in the public API of
the package. We can separate the internal and external "util" methods
later on if there is any demand for this.
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 96bac9f into main Sep 21, 2021
@Gudahtt Gudahtt deleted the add-subpath-exports branch September 21, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants