Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split into multiple modules #211

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Split into multiple modules #211

merged 2 commits into from
Sep 21, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 17, 2021

The source is now split into modules according to category, along with the unit tests. This should make the package easier to navigate.

There are no functional changes. For the most part, things were just moved around. A few tests were added for the index module as well, to avoid a drop in code coverage.

The main change aside from that is the import style. We're now using named imports everywhere rather than * as <name>.

The source is now split into modules according to category, along with
the unit tests. This should make the package easier to navigate.

There are no functional changes. For the most part, things were just
moved around. A few tests were added for the index module as well, to
avoid a drop in code coverage.

The main change aside from that is the import style. We're now using
named imports everywhere rather than `* as <name>`.
@Gudahtt Gudahtt requested a review from a team as a code owner September 17, 2021 03:44
@kumavis
Copy link
Member

kumavis commented Sep 20, 2021

consider updating the package.json field exports to allow pulling in just the relevant parts https://nodejs.org/api/packages.html#packages_subpath_exports

@Gudahtt Gudahtt merged commit fa0f1a4 into main Sep 21, 2021
@Gudahtt Gudahtt deleted the split-into-multiple-modules branch September 21, 2021 12:59
@Gudahtt
Copy link
Member Author

Gudahtt commented Sep 21, 2021

@kumavis Good idea! I have added those here: #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants