Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypedDataUtils.findTypeDependencies tests #169

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Add TypedDataUtils.findTypeDependencies tests #169

merged 1 commit into from
Aug 16, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 11, 2021

This function is now comprehensively tested.

@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 11, 2021 •
edited
Loading

This depends upon #167

@Gudahtt Gudahtt force-pushed the add-find-type-dependencies-tests branch from 5f90876 to f8bb67c Compare August 11, 2021 22:33
@Gudahtt Gudahtt mentioned this pull request Aug 11, 2021
Merged
@Gudahtt Gudahtt force-pushed the add-find-type-dependencies-tests branch from f8bb67c to 66ea1b2 Compare August 11, 2021 23:40
@Gudahtt Gudahtt changed the base branch from add-encode-type-tests to main August 11, 2021 23:40
@Gudahtt Gudahtt marked this pull request as ready for review August 11, 2021 23:40
@Gudahtt Gudahtt requested a review from a team as a code owner August 11, 2021 23:40
rekmarks
rekmarks previously approved these changes Aug 15, 2021
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let me also suggest that we do this: #179

@Gudahtt Gudahtt force-pushed the add-find-type-dependencies-tests branch from 66ea1b2 to 9a4166f Compare August 16, 2021 12:04
@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 16, 2021

This has been rebased to resolve conflicts

@Gudahtt
Add TypedDataUtils.findTypeDependencies tests
d36bfa4 
This function is now comprehensively tested.
@Gudahtt Gudahtt force-pushed the add-find-type-dependencies-tests branch from 9a4166f to d36bfa4 Compare August 16, 2021 12:34
rekmarks
rekmarks approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 5c40150 into main Aug 16, 2021
@Gudahtt Gudahtt deleted the add-find-type-dependencies-tests branch August 16, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gudahtt @rekmarks