From 30ab202bb7e12906939c16e8b1bae85bb569d02d Mon Sep 17 00:00:00 2001 From: Whymarrh Whitby Date: Tue, 21 Jan 2020 14:46:35 -0330 Subject: [PATCH] Switch numbers to constants --- config/index.js | 248 +++++++++++++++++++++---------------------- config/jest.js | 80 +++++++------- config/typescript.js | 84 +++++++-------- 3 files changed, 206 insertions(+), 206 deletions(-) diff --git a/config/index.js b/config/index.js index 0573d4d2..7ef4b6ef 100644 --- a/config/index.js +++ b/config/index.js @@ -4,129 +4,129 @@ module.exports = { 'shared-node-browser': true, }, rules: { - 'accessor-pairs': 2, - 'arrow-spacing': [2, { 'before': true, 'after': true }], - 'block-spacing': [2, 'always'], - 'brace-style': 2, - 'camelcase': [2, { 'properties': 'never', 'allow': ['^UNSAFE_'] }], - 'comma-dangle': [2, 'always-multiline'], - 'comma-spacing': [2, { 'before': false, 'after': true }], - 'comma-style': [2, 'last'], - 'constructor-super': 2, - 'curly': 2, - 'default-case': 2, - 'dot-location': [2, 'property'], - 'eol-last': 2, - 'eqeqeq': [2, 'allow-null'], - 'generator-star-spacing': [2, { 'before': true, 'after': true }], - 'handle-callback-err': [2, '^(err|error)$' ], - 'indent': [2, 2, { 'SwitchCase': 1 }], - 'jsx-quotes': [2, 'prefer-double'], - 'key-spacing': 2, - 'keyword-spacing': [2, { 'before': true, 'after': true }], - 'new-cap': [2, { 'newIsCap': true, 'capIsNew': false }], - 'new-parens': 2, - 'no-array-constructor': 2, - 'no-async-promise-executor': 2, - 'no-caller': 2, - 'no-class-assign': 2, - 'no-cond-assign': 2, - 'no-confusing-arrow': 2, - 'no-const-assign': 2, - 'no-control-regex': 2, - 'no-debugger': 2, - 'no-delete-var': 2, - 'no-dupe-args': 2, - 'no-dupe-class-members': 2, - 'no-dupe-keys': 2, - 'no-duplicate-case': 2, - 'no-duplicate-imports': 2, - 'no-empty-character-class': 2, - 'no-empty-pattern': 2, - 'no-eval': 2, - 'no-ex-assign': 2, - 'no-extend-native': 2, - 'no-extra-bind': 2, - 'no-extra-boolean-cast': 2, - 'no-extra-parens': [2, 'functions'], - 'no-fallthrough': 2, - 'no-floating-decimal': 2, - 'no-func-assign': 2, - 'no-implied-eval': 2, - 'no-inner-declarations': [2, 'functions'], - 'no-invalid-regexp': 2, - 'no-irregular-whitespace': 2, - 'no-iterator': 2, - 'no-label-var': 2, - 'no-labels': [2, { 'allowLoop': false, 'allowSwitch': false }], - 'no-lone-blocks': 2, - 'no-mixed-spaces-and-tabs': 2, - 'no-multi-spaces': 2, - 'no-multi-str': 2, - 'no-multiple-empty-lines': [2, { 'max': 2 }], - 'no-native-reassign': 2, - 'no-negated-in-lhs': 2, - 'no-new': 2, - 'no-new-func': 2, - 'no-new-object': 2, - 'no-new-require': 2, - 'no-new-symbol': 2, - 'no-new-wrappers': 2, - 'no-obj-calls': 2, - 'no-octal': 2, - 'no-octal-escape': 2, - 'no-path-concat': 2, - 'no-proto': 2, - 'no-redeclare': 2, - 'no-regex-spaces': 2, - 'no-restricted-globals': [2, 'event'], - 'no-return-assign': [2, 'except-parens'], - 'no-self-assign': 2, - 'no-self-compare': 2, - 'no-sequences': 2, - 'no-shadow-restricted-names': 2, - 'no-spaced-func': 2, - 'no-sparse-arrays': 2, - 'no-this-before-super': 2, - 'no-throw-literal': 2, - 'no-trailing-spaces': 2, - 'no-undef': 2, - 'no-undef-init': 2, - 'no-unexpected-multiline': 2, - 'no-unmodified-loop-condition': 2, - 'no-unneeded-ternary': [2, { 'defaultAssignment': false }], - 'no-unreachable': 2, - 'no-unsafe-finally': 2, - 'no-unused-expressions': [2, { 'allowShortCircuit': true, 'allowTernary': true }], - 'no-unused-vars': [2, { 'vars': 'all', 'args': 'all', 'argsIgnorePattern': '[_]+' }], - 'no-use-before-define': [2, { 'functions': false }], - 'no-useless-call': 2, - 'no-useless-computed-key': 2, - 'no-useless-constructor': 2, - 'no-useless-escape': 2, - 'no-var': 2, - 'no-whitespace-before-property': 2, - 'no-with': 2, - 'object-curly-spacing': [2, 'always'], - 'one-var': [2, { 'initialized': 'never' }], - 'operator-linebreak': [2, 'after', { 'overrides': { '?': 'ignore', ':': 'ignore' } }], - 'padded-blocks': 0, - 'prefer-const': 2, - 'quotes': [2, 'single', { 'avoidEscape': true, 'allowTemplateLiterals': true }], - 'semi': [2, 'never'], - 'semi-spacing': [2, { 'before': false, 'after': true }], - 'space-before-blocks': [2, 'always'], - 'space-before-function-paren': [2, 'always'], - 'space-in-parens': [2, 'never'], - 'space-infix-ops': 2, - 'space-unary-ops': [2, { 'words': true, 'nonwords': false }], - 'spaced-comment': [2, 'always', { 'markers': ['global', 'globals', 'eslint', 'eslint-disable', '*package', '!', ','], 'exceptions': ['=', '-'] } ], - 'strict': 0, - 'template-curly-spacing': [2, 'never'], - 'use-isnan': 2, - 'valid-typeof': 2, - 'wrap-iife': [2, 'any'], - 'yield-star-spacing': [2, 'both'], - 'yoda': [2, 'never'], + 'accessor-pairs': 'error', + 'arrow-spacing': ['error', { 'before': true, 'after': true }], + 'block-spacing': ['error', 'always'], + 'brace-style': 'error', + 'camelcase': ['error', { 'properties': 'never', 'allow': ['^UNSAFE_'] }], + 'comma-dangle': ['error', 'always-multiline'], + 'comma-spacing': ['error', { 'before': false, 'after': true }], + 'comma-style': ['error', 'last'], + 'constructor-super': 'error', + 'curly': 'error', + 'default-case': 'error', + 'dot-location': ['error', 'property'], + 'eol-last': 'error', + 'eqeqeq': ['error', 'allow-null'], + 'generator-star-spacing': ['error', { 'before': true, 'after': true }], + 'handle-callback-err': ['error', '^(err|error)$' ], + 'indent': ['error', 'error', { 'SwitchCase': 1 }], + 'jsx-quotes': ['error', 'prefer-double'], + 'key-spacing': 'error', + 'keyword-spacing': ['error', { 'before': true, 'after': true }], + 'new-cap': ['error', { 'newIsCap': true, 'capIsNew': false }], + 'new-parens': 'error', + 'no-array-constructor': 'error', + 'no-async-promise-executor': 'error', + 'no-caller': 'error', + 'no-class-assign': 'error', + 'no-cond-assign': 'error', + 'no-confusing-arrow': 'error', + 'no-const-assign': 'error', + 'no-control-regex': 'error', + 'no-debugger': 'error', + 'no-delete-var': 'error', + 'no-dupe-args': 'error', + 'no-dupe-class-members': 'error', + 'no-dupe-keys': 'error', + 'no-duplicate-case': 'error', + 'no-duplicate-imports': 'error', + 'no-empty-character-class': 'error', + 'no-empty-pattern': 'error', + 'no-eval': 'error', + 'no-ex-assign': 'error', + 'no-extend-native': 'error', + 'no-extra-bind': 'error', + 'no-extra-boolean-cast': 'error', + 'no-extra-parens': ['error', 'functions'], + 'no-fallthrough': 'error', + 'no-floating-decimal': 'error', + 'no-func-assign': 'error', + 'no-implied-eval': 'error', + 'no-inner-declarations': ['error', 'functions'], + 'no-invalid-regexp': 'error', + 'no-irregular-whitespace': 'error', + 'no-iterator': 'error', + 'no-label-var': 'error', + 'no-labels': ['error', { 'allowLoop': false, 'allowSwitch': false }], + 'no-lone-blocks': 'error', + 'no-mixed-spaces-and-tabs': 'error', + 'no-multi-spaces': 'error', + 'no-multi-str': 'error', + 'no-multiple-empty-lines': ['error', { 'max': 2 }], + 'no-native-reassign': 'error', + 'no-negated-in-lhs': 'error', + 'no-new': 'error', + 'no-new-func': 'error', + 'no-new-object': 'error', + 'no-new-require': 'error', + 'no-new-symbol': 'error', + 'no-new-wrappers': 'error', + 'no-obj-calls': 'error', + 'no-octal': 'error', + 'no-octal-escape': 'error', + 'no-path-concat': 'error', + 'no-proto': 'error', + 'no-redeclare': 'error', + 'no-regex-spaces': 'error', + 'no-restricted-globals': ['error', 'event'], + 'no-return-assign': ['error', 'except-parens'], + 'no-self-assign': 'error', + 'no-self-compare': 'error', + 'no-sequences': 'error', + 'no-shadow-restricted-names': 'error', + 'no-spaced-func': 'error', + 'no-sparse-arrays': 'error', + 'no-this-before-super': 'error', + 'no-throw-literal': 'error', + 'no-trailing-spaces': 'error', + 'no-undef': 'error', + 'no-undef-init': 'error', + 'no-unexpected-multiline': 'error', + 'no-unmodified-loop-condition': 'error', + 'no-unneeded-ternary': ['error', { 'defaultAssignment': false }], + 'no-unreachable': 'error', + 'no-unsafe-finally': 'error', + 'no-unused-expressions': ['error', { 'allowShortCircuit': true, 'allowTernary': true }], + 'no-unused-vars': ['error', { 'vars': 'all', 'args': 'all', 'argsIgnorePattern': '[_]+' }], + 'no-use-before-define': ['error', { 'functions': false }], + 'no-useless-call': 'error', + 'no-useless-computed-key': 'error', + 'no-useless-constructor': 'error', + 'no-useless-escape': 'error', + 'no-var': 'error', + 'no-whitespace-before-property': 'error', + 'no-with': 'error', + 'object-curly-spacing': ['error', 'always'], + 'one-var': ['error', { 'initialized': 'never' }], + 'operator-linebreak': ['error', 'after', { 'overrides': { '?': 'ignore', ':': 'ignore' } }], + 'padded-blocks': 'off', + 'prefer-const': 'error', + 'quotes': ['error', 'single', { 'avoidEscape': true, 'allowTemplateLiterals': true }], + 'semi': ['error', 'never'], + 'semi-spacing': ['error', { 'before': false, 'after': true }], + 'space-before-blocks': ['error', 'always'], + 'space-before-function-paren': ['error', 'always'], + 'space-in-parens': ['error', 'never'], + 'space-infix-ops': 'error', + 'space-unary-ops': ['error', { 'words': true, 'nonwords': false }], + 'spaced-comment': ['error', 'always', { 'markers': ['global', 'globals', 'eslint', 'eslint-disable', '*package', '!', ','], 'exceptions': ['=', '-'] } ], + 'strict': 'off', + 'template-curly-spacing': ['error', 'never'], + 'use-isnan': 'error', + 'valid-typeof': 'error', + 'wrap-iife': ['error', 'any'], + 'yield-star-spacing': ['error', 'both'], + 'yoda': ['error', 'never'], }, } diff --git a/config/jest.js b/config/jest.js index cc39df38..005d5548 100644 --- a/config/jest.js +++ b/config/jest.js @@ -6,45 +6,45 @@ module.exports = { 'jest/globals': true, }, rules: { - 'jest/consistent-test-it': [2, { 'fn': 'it' }], - 'jest/expect-expect': 2, - 'jest/lowercase-name': 2, - 'jest/no-alias-methods': 0, - 'jest/no-commented-out-tests': 2, - 'jest/no-disabled-tests': 2, - 'jest/no-duplicate-hooks': 2, - 'jest/no-expect-resolves': 2, - 'jest/no-export': 2, - 'jest/no-focused-tests': 2, - 'jest/no-hooks': 0, - 'jest/no-identical-title': 2, - 'jest/no-if': 2, - 'jest/no-jasmine-globals': 2, - 'jest/no-jest-import': 2, - 'jest/no-large-snapshots': 0, - 'jest/no-mocks-import': 2, - 'jest/no-standalone-expect': 2, - 'jest/no-test-callback': 2, - 'jest/no-test-prefixes': 2, - 'jest/no-test-return-statement': 2, - 'jest/no-truthy-falsy': 2, - 'jest/no-try-expect': 2, - 'jest/prefer-called-with': 0, - 'jest/prefer-expect-assertions': 0, - 'jest/prefer-hooks-on-top': 2, - 'jest/prefer-inline-snapshots': 0, - 'jest/prefer-spy-on': 2, - 'jest/prefer-strict-equal': 2, - 'jest/prefer-to-be-null': 2, - 'jest/prefer-to-be-undefined': 2, - 'jest/prefer-to-contain': 2, - 'jest/prefer-to-have-length': 2, - 'jest/prefer-todo': 2, - 'jest/require-top-level-describe': 2, - 'jest/require-to-throw-message': 2, - 'jest/valid-describe': 2, - 'jest/valid-expect-in-promise': 2, - 'jest/valid-expect': [2, { 'alwaysAwait': true }], - 'jest/valid-title': 2, + 'jest/consistent-test-it': ['error', { 'fn': 'it' }], + 'jest/expect-expect': 'error', + 'jest/lowercase-name': 'error', + 'jest/no-alias-methods': 'off', + 'jest/no-commented-out-tests': 'error', + 'jest/no-disabled-tests': 'error', + 'jest/no-duplicate-hooks': 'error', + 'jest/no-expect-resolves': 'error', + 'jest/no-export': 'error', + 'jest/no-focused-tests': 'error', + 'jest/no-hooks': 'off', + 'jest/no-identical-title': 'error', + 'jest/no-if': 'error', + 'jest/no-jasmine-globals': 'error', + 'jest/no-jest-import': 'error', + 'jest/no-large-snapshots': 'off', + 'jest/no-mocks-import': 'error', + 'jest/no-standalone-expect': 'error', + 'jest/no-test-callback': 'error', + 'jest/no-test-prefixes': 'error', + 'jest/no-test-return-statement': 'error', + 'jest/no-truthy-falsy': 'error', + 'jest/no-try-expect': 'error', + 'jest/prefer-called-with': 'off', + 'jest/prefer-expect-assertions': 'off', + 'jest/prefer-hooks-on-top': 'error', + 'jest/prefer-inline-snapshots': 'off', + 'jest/prefer-spy-on': 'error', + 'jest/prefer-strict-equal': 'error', + 'jest/prefer-to-be-null': 'error', + 'jest/prefer-to-be-undefined': 'error', + 'jest/prefer-to-contain': 'error', + 'jest/prefer-to-have-length': 'error', + 'jest/prefer-todo': 'error', + 'jest/require-top-level-describe': 'error', + 'jest/require-to-throw-message': 'error', + 'jest/valid-describe': 'error', + 'jest/valid-expect-in-promise': 'error', + 'jest/valid-expect': ['error', { 'alwaysAwait': true }], + 'jest/valid-title': 'error', }, } diff --git a/config/typescript.js b/config/typescript.js index 870f7ed9..bf04ccaa 100644 --- a/config/typescript.js +++ b/config/typescript.js @@ -11,64 +11,64 @@ module.exports = { ], rules: { // Rules from @typescript-eslint/eslint-plugin - '@typescript-eslint/array-type': 2, - '@typescript-eslint/consistent-type-definitions': [2, 'type'], - '@typescript-eslint/no-explicit-any': 0, - '@typescript-eslint/prefer-for-of': 0, - '@typescript-eslint/prefer-function-type': 2, - '@typescript-eslint/prefer-optional-chain': 2, - '@typescript-eslint/triple-slash-reference': 2, - '@typescript-eslint/type-annotation-spacing': 2, - '@typescript-eslint/typedef': 0, - '@typescript-eslint/unified-signatures': 2, + '@typescript-eslint/array-type': 'error', + '@typescript-eslint/consistent-type-definitions': ['error', 'type'], + '@typescript-eslint/no-explicit-any': 'off', + '@typescript-eslint/prefer-for-of': 'off', + '@typescript-eslint/prefer-function-type': 'error', + '@typescript-eslint/prefer-optional-chain': 'error', + '@typescript-eslint/triple-slash-reference': 'error', + '@typescript-eslint/type-annotation-spacing': 'error', + '@typescript-eslint/typedef': 'off', + '@typescript-eslint/unified-signatures': 'error', // "Extension Rules" from @typescript-eslint/eslint-plugin - '@typescript-eslint/brace-style': 2, - 'brace-style': 0, + '@typescript-eslint/brace-style': 'error', + 'brace-style': 'off', - '@typescript-eslint/default-param-last': 2, - 'default-param-last': 0, + '@typescript-eslint/default-param-last': 'error', + 'default-param-last': 'off', - '@typescript-eslint/func-call-spacing': 2, - 'func-call-spacing': 0, + '@typescript-eslint/func-call-spacing': 'error', + 'func-call-spacing': 'off', - '@typescript-eslint/indent': [2, 2, { 'SwitchCase': 1 }], - 'indent': 0, + '@typescript-eslint/indent': ['error', 'error', { 'SwitchCase': 1 }], + 'indent': 'off', - '@typescript-eslint/no-array-constructor': 2, - 'no-array-constructor': 0, + '@typescript-eslint/no-array-constructor': 'error', + 'no-array-constructor': 'off', - '@typescript-eslint/no-empty-function': 2, - 'no-empty-function': 0, + '@typescript-eslint/no-empty-function': 'error', + 'no-empty-function': 'off', - '@typescript-eslint/no-extra-parens': 0, - 'no-extra-parens': 0, + '@typescript-eslint/no-extra-parens': 'off', + 'no-extra-parens': 'off', - '@typescript-eslint/no-extra-semi': 2, - 'no-extra-semi': 0, + '@typescript-eslint/no-extra-semi': 'error', + 'no-extra-semi': 'off', - '@typescript-eslint/no-magic-numbers': 0, - 'no-magic-numbers': 0, + '@typescript-eslint/no-magic-numbers': 'off', + 'no-magic-numbers': 'off', - '@typescript-eslint/no-unused-expressions': [2, { 'allowShortCircuit': true, 'allowTernary': true }], - 'no-unused-expressions': 0, + '@typescript-eslint/no-unused-expressions': ['error', { 'allowShortCircuit': true, 'allowTernary': true }], + 'no-unused-expressions': 'off', - '@typescript-eslint/no-unused-vars': [2, { 'vars': 'all', 'args': 'all', 'argsIgnorePattern': '[_]+' }], - 'no-unused-vars': 0, + '@typescript-eslint/no-unused-vars': ['error', { 'vars': 'all', 'args': 'all', 'argsIgnorePattern': '[_]+' }], + 'no-unused-vars': 'off', - '@typescript-eslint/no-use-before-define': [2, { 'functions': false }], - 'no-use-before-define': 0, + '@typescript-eslint/no-use-before-define': ['error', { 'functions': false }], + 'no-use-before-define': 'off', - '@typescript-eslint/no-useless-constructor': 2, - 'no-useless-constructor': 0, + '@typescript-eslint/no-useless-constructor': 'error', + 'no-useless-constructor': 'off', - '@typescript-eslint/quotes': [2, 'single', { 'avoidEscape': true, 'allowTemplateLiterals': true }], - 'quotes': 0, + '@typescript-eslint/quotes': ['error', 'single', { 'avoidEscape': true, 'allowTemplateLiterals': true }], + 'quotes': 'off', - '@typescript-eslint/semi': [2, 'always'], - 'semi': 0, + '@typescript-eslint/semi': ['error', 'always'], + 'semi': 'off', - '@typescript-eslint/space-before-function-paren': [2, 'always'], - 'space-before-function-paren': 0, + '@typescript-eslint/space-before-function-paren': ['error', 'always'], + 'space-before-function-paren': 'off', }, }