feat: add tracing to multichain account service #7006
+493
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
montelaidev
force-pushed
the
fix/mul-1186
branch
from
5a26cc8 to
3190bca
Compare
ccharly
reviewed
Oct 30, 2025
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
|
@metamaskbot publish-preview |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
reviewed
Oct 31, 2025
| @@ -0,0 +1,4 @@ | |||
| export enum TraceName { | |||
| 'SnapDiscoverAccounts' = 'Snap Discover Accounts', | |||
There was a problem hiding this comment.
I still think Snap* is too generic. Since we're providing the providerName in the trace parameter, maybe we can just use DiscoverAccounts for any providers instead? And we always pass a providerName parameter?
| { | ||
| name: TraceName.EvmDiscoverAccounts, | ||
| data: { | ||
| providerName: this.getName(), |
There was a problem hiding this comment.
I'd just rename providerName to provider in this context
| const mockTrace = jest.fn().mockImplementation(async (request, fn) => { | ||
| expect(request.name).toBe('EVM Discover Accounts'); | ||
| expect(request.data).toStrictEqual({ | ||
| providerName: 'EVM', |
There was a problem hiding this comment.
let's use the constant EVM_ACCOUNT_PROVIDER_NAME here
| const mockTrace = jest.fn().mockImplementation(async (request, fn) => { | ||
| expect(request.name).toBe('EVM Discover Accounts'); | ||
| expect(request.data).toStrictEqual({ | ||
| providerName: 'EVM', |
There was a problem hiding this comment.
Same, use the constant here too
Comment on lines
10
to
12
| ### Changed | ||
|
|
||
| - Adds an optional trace argument to MultichainAccountService and MultichainAccountWallet ([#7006](https://github.com/MetaMask/core/pull/7006)) |
There was a problem hiding this comment.
Suggested change
| ### Changed | |
| - Adds an optional trace argument to MultichainAccountService and MultichainAccountWallet ([#7006](https://github.com/MetaMask/core/pull/7006)) | |
| ### Added | |
| - Add optional tracing configuration ([#7006](https://github.com/MetaMask/core/pull/7006)) | |
| - For now, only the account discovery is being traced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds traces to the Multichain Account Service.
References
Checklist
Note
Adds optional tracing (with fallback) and wraps EVM and snap-based account discovery in trace spans, with comprehensive tests.
config.trace: TraceCallbacktoMultichainAccountService; default totraceFallback.TraceNameenum andtraceFallbackinsrc/analyticsand export viaanalytics/index.EvmAccountProvider.discoverAccountsnow runs within a trace span (EVM Discover Accounts) and constructor accepts optional trace callback.AccountProviderWrapper.discoverAccountstraces usingSnap Discover AccountsorEVM Discover Accountsbased on provider.MultichainAccountService,EvmAccountProvider,AccountProviderWrapper, and analytics utilities.Written by Cursor Bugbot for commit a06ed0a. This will update automatically on new commits. Configure here.