fix: remove includeDuplicateSymbolAssets filter #4768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hurricanenara
approved these changes
Oct 8, 2024
cryptodev-2s
approved these changes
Oct 8, 2024
sahar-fehri
added a commit
that referenced
this pull request
Oct 10, 2024
## Explanation This is an RC for v216.0.0 ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Changelog ### `@metamask/assets-controllers` - The `includeDuplicateSymbolAssets` param is removed from our api call to TokenApi ([#4768](#4768)) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
What motivates this change is this user report MetaMask/metamask-extension#27614
Based on discussions we had with teams; seems like initially, we added the
includeDuplicateSymbolAssetsbecause there were concerns around duplicate symbols being scammy and the increased size of tokenList.For the duplicate symbols being scammy concern; i think our usage of
occurrencesFloor=3is helping us filter out any scam tokens.Having tokens with the same symbol is not unusual and it does not necessarily mean that the token is a scam.
For the tokenList size; we thought that; today; the tokenList we get without
includeDuplicateSymbolAssetshas around 4500 tokens. With theincludeDuplicateSymbolAssetsit has around 4000. Which does not seem like it should have a huge impact. We thought that token the tokenList size would increase regardless in future, and if users add their tokens to lists and expect to see them we should not be filtering them out even if they have duplicates.References
Changelog
@metamask/assets-controllersincludeDuplicateSymbolAssetsin our api call to token-api.Checklist