feat: align transaction controller with mobile patch #4706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
approved these changes
Sep 16, 2024
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
deleted the
feat/transaction-controller-mobile-patch-align
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The remaining changes in the mobile
TransactionControllerpatch are all additions to the logic.Adopting them here will remove the need for the patch while still supporting the extension usage.
Specifically:
submitHistorystate when submitting a transaction to the RPC provider, including cancel and speed up but excluding automatic resubmit.getPermittedAccountsand associated origin validation optional.IncomingTransactionHelper.References
Changelog
@metamask/transaction-controllersubmitHistoryin state when submitting transactions to network.CHAIN_IDS,ETHERSCAN_SUPPORTED_NETWORKSandSPEED_UP_RATEconstants.getPermittedAccountsconstructor callback optional.Checklist