Skip to content

Conversation

@sahar-fehri
Copy link
Contributor

This is the release candidate for 129.0.0. It adds an export for const SUPPORTED_CHAIN_IDS.
#4079

@sahar-fehri sahar-fehri requested a review from a team as a code owner March 19, 2024 13:16
@MajorLift
Copy link
Contributor

MajorLift commented Mar 19, 2024

Could this release maybe wait to include some or all of the following PRs you currently have open?

@sahar-fehri
Copy link
Contributor Author

Could this release maybe wait to include some or all of the following PRs you currently have open?

Hey @MajorLift !
I inititially thought that it would be a quick and easy release, i have one bug fix PR on extension that i wanted to get in.
It can definitely wait for the rest if you think it is better.
Just want to mention:

@sahar-fehri sahar-fehri requested a review from MajorLift March 19, 2024 14:48
@MajorLift
Copy link
Contributor

If this is urgent, we can definitely go ahead without waiting. Batching updates together is preferable, but keeping this PR open for too long and blocking other releases is also a concern.

I'll leave it up to you to merge this or wait to include #4030 based on your timeline.

MajorLift
MajorLift previously approved these changes Mar 19, 2024
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with releasing the changes outlined here for now and releasing more later, but I did have a comment about one of the changes.

@sahar-fehri sahar-fehri requested a review from mcmire March 19, 2024 16:38
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sahar-fehri sahar-fehri merged commit b89ffd3 into main Mar 19, 2024
@sahar-fehri sahar-fehri deleted the release/129.0.0 branch March 19, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants