Skip to content

Conversation

@sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Mar 19, 2024

Explanation

PR to export SUPPORTED_CHAIN_IDS constant.
This constant is imported in extension like this:
import { SUPPORTED_CHAIN_IDS } from '@metamask/assets-controllers/dist/token-prices-service/codefi-v2';
Which was causing issues when trying to upgrade assets-controllers to latest. It was not able to find it.
With this change we can import it like this instead of from dist which can abstract how the code is transpiled;
import { SUPPORTED_CHAIN_IDS } from '@metamask/assets-controllers';

References

Changelog

@metamask/assets-controllers

  • ADDED: Added export for const SUPPORTED_CHAIN_IDS

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@sahar-fehri sahar-fehri requested a review from a team as a code owner March 19, 2024 11:02
@sahar-fehri sahar-fehri changed the title fix: export var fix: export const Mar 19, 2024
@sahar-fehri sahar-fehri requested a review from Gudahtt March 19, 2024 12:06
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one non-blocking suggested for an additional unit test

@sahar-fehri sahar-fehri merged commit 4bcebf6 into main Mar 19, 2024
@sahar-fehri sahar-fehri deleted the fix/export-chainIds-var branch March 19, 2024 13:03
@sahar-fehri sahar-fehri mentioned this pull request Mar 19, 2024
sahar-fehri added a commit that referenced this pull request Mar 19, 2024
This is the release candidate for 129.0.0. It adds an export for const
SUPPORTED_CHAIN_IDS.
#4079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants