Add script to update changelogs of a release candidate #3668
Conversation
cryptodev-2s
added
the
team-wallet-framework
cryptodev-2s
changed the title
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Thanks for doing this. We should also make sure to add a Yarn constraint in constraints.pro that enforces that all packages have a changelog:update package script. You should be able to copy the existing one for changelog:validate here: https://github.com/MetaMask/core/blob/main/constraints.pro#L269
Constraint added, but actually both they only check if it's valid no error is thrown if it doesn't exist |
|
Oh! Hmm. Alright, I guess we can fix that issue in another PR. |
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
One fix needed, but this is otherwise good to go!
## Explanation Update the template used by the `create-package` script. The previous template was no longer compatible with our Yarn constraints. ## References Here are the PRs related to these specific changes: * #4648 * #3645 * #1390 * #3668 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Explanation
Add script
scripts/update-changelog.shfor updating changelogs of a release candidateReferences
Checklist